Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScheduledAction.h

Issue 2568103002: Revert of Eagerly dispose of ScheduledActions. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2009 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 : public GarbageCollectedFinalized<ScheduledAction> { 49 : public GarbageCollectedFinalized<ScheduledAction> {
50 WTF_MAKE_NONCOPYABLE(ScheduledAction); 50 WTF_MAKE_NONCOPYABLE(ScheduledAction);
51 51
52 public: 52 public:
53 static ScheduledAction* create(ScriptState*, 53 static ScheduledAction* create(ScriptState*,
54 const ScriptValue& handler, 54 const ScriptValue& handler,
55 const Vector<ScriptValue>& arguments); 55 const Vector<ScriptValue>& arguments);
56 static ScheduledAction* create(ScriptState*, const String& handler); 56 static ScheduledAction* create(ScriptState*, const String& handler);
57 57
58 ~ScheduledAction(); 58 ~ScheduledAction();
59 void dispose();
60
61 DECLARE_TRACE(); 59 DECLARE_TRACE();
62 60
63 void execute(ExecutionContext*); 61 void execute(ExecutionContext*);
64 62
65 private: 63 private:
66 ScheduledAction(ScriptState*, 64 ScheduledAction(ScriptState*,
67 const ScriptValue& handler, 65 const ScriptValue& handler,
68 const Vector<ScriptValue>& arguments); 66 const Vector<ScriptValue>& arguments);
69 ScheduledAction(ScriptState*, const String& handler); 67 ScheduledAction(ScriptState*, const String& handler);
70 68
71 void execute(LocalFrame*); 69 void execute(LocalFrame*);
72 void execute(WorkerGlobalScope*); 70 void execute(WorkerGlobalScope*);
73 void createLocalHandlesForArgs(Vector<v8::Local<v8::Value>>* handles); 71 void createLocalHandlesForArgs(Vector<v8::Local<v8::Value>>* handles);
74 72
75 ScriptStateProtectingContext m_scriptState; 73 ScriptStateProtectingContext m_scriptState;
76 ScopedPersistent<v8::Function> m_function; 74 ScopedPersistent<v8::Function> m_function;
77 V8PersistentValueVector<v8::Value> m_info; 75 V8PersistentValueVector<v8::Value> m_info;
78 ScriptSourceCode m_code; 76 ScriptSourceCode m_code;
79 }; 77 };
80 78
81 } // namespace blink 79 } // namespace blink
82 80
83 #endif // ScheduledAction 81 #endif // ScheduledAction
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698