Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py

Issue 2568033003: [Telemetry] Increase timeout after sending SIGTERM (Closed)
Patch Set: Address Ken's comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
diff --git a/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
index ca34f90eaecd85569196b5ff693aee4a19ea5f5c..0b7ac768dcc33d1cdca7158eb59209e86857ed12 100644
--- a/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
+++ b/telemetry/telemetry/internal/backends/chrome/desktop_browser_backend.py
@@ -616,7 +616,9 @@ class DesktopBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
if self.IsBrowserRunning():
self._proc.terminate()
try:
- py_utils.WaitFor(lambda: not self.IsBrowserRunning(), timeout=5)
+ # Increased from 5 to increase the likelihood of getting a strack trace.
+ # See https://github.com/catapult-project/catapult/issues/3074.
+ py_utils.WaitFor(lambda: not self.IsBrowserRunning(), timeout=20)
self._proc = None
except py_utils.TimeoutException:
logging.warning('Failed to gracefully shutdown.')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698