Forbid components/ui_devtools:ui_devtools exporting symbols.

Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=669352
Committed: https://crrev.com/030d74f466988680ff7dbe644954569f447975f3
Cr-Commit-Position: refs/heads/master@{#438002}

[leonhsl(Using Gerrit), 2016-12-12 07:20:59]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 07:21:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2016-12-12 08:12:29]

Description was changed from

==========
Fix a warning LNK4217 for win component build.

Header files in a source_set target should not use dllexport/dllimport.

BUG=
==========

to

==========
Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=
==========

[leonhsl(Using Gerrit), 2016-12-12 08:16:42]

leon.han@intel.com changed reviewers:
+ sadrul@chromium.org

[leonhsl(Using Gerrit), 2016-12-12 08:16:42]

Hi, would you PTAL at this? Thanks.

[commit-bot: I haz the power, 2016-12-12 08:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 08:47:52]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[leonhsl(Using Gerrit), 2016-12-12 08:54:38]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 08:54:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 10:14:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 10:14:59]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-12-12 20:15:33]

lgtm I think this fixes crbug.com/669352? Can you add that to the BUG= line in
the CL description? Thanks!

[leonhsl(Using Gerrit), 2016-12-13 02:43:06]

Description was changed from

==========
Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=
==========

to

==========
Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=669352
==========

[leonhsl(Using Gerrit), 2016-12-13 02:44:31]

On 2016/12/12 20:15:33, sadrul wrote:
> lgtm I think this fixes crbug.com/669352? Can you add that to the BUG= line in
> the CL description? Thanks!

Done. Thanks for review and will send to CQ now.

[leonhsl(Using Gerrit), 2016-12-13 02:44:40]

The CQ bit was checked by leon.han@intel.com

[commit-bot: I haz the power, 2016-12-13 02:45:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:52:22]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481597080727720, "parent_rev":
"1809bf3cf96fe983c88b1d39afacdcdbc8a634a6", "commit_rev":
"3a660de3199944f53e79d62055aaab5925ef16de"}

[commit-bot: I haz the power, 2016-12-13 02:52:47]

Description was changed from

==========
Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=669352
==========

to

==========
Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=669352

Review-Url: https://codereview.chromium.org/2568003002
==========

[commit-bot: I haz the power, 2016-12-13 02:52:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 02:56:56]

Description was changed from

==========
Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=669352

Review-Url: https://codereview.chromium.org/2568003002
==========

to

==========
Forbid components/ui_devtools:ui_devtools exporting symbols.

components/ui_devtools:ui_devtools is a source_set target depended on
by chrome/browser/ui:ui and ash:ash, which just embed ui_devtools and do not
expect it to export any symbols out.

BUG=669352

Committed: https://crrev.com/030d74f466988680ff7dbe644954569f447975f3
Cr-Commit-Position: refs/heads/master@{#438002}
==========

[commit-bot: I haz the power, 2016-12-13 02:56:57]

Patchset 1 (id:??) landed as
https://crrev.com/030d74f466988680ff7dbe644954569f447975f3
Cr-Commit-Position: refs/heads/master@{#438002}