Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: components/ui_devtools/devtools_server.h

Issue 2568003002: Forbid components/ui_devtools:ui_devtools exporting symbols. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ui_devtools/devtools_server.h
diff --git a/components/ui_devtools/devtools_server.h b/components/ui_devtools/devtools_server.h
index 4060184fc108bc5905ec9f8e9a21210753319fac..7dfc02cb5e1156077d715edaf7101eac318c6495 100644
--- a/components/ui_devtools/devtools_server.h
+++ b/components/ui_devtools/devtools_server.h
@@ -13,7 +13,6 @@
#include "components/ui_devtools/Forward.h"
#include "components/ui_devtools/Protocol.h"
#include "components/ui_devtools/devtools_client.h"
-#include "components/ui_devtools/devtools_export.h"
#include "components/ui_devtools/string_util.h"
#include "net/server/http_server.h"
@@ -26,12 +25,12 @@ class UiDevToolsServer : public net::HttpServer::Delegate {
// Returns an empty unique_ptr if ui devtools flag isn't enabled or if a
// server instance has already been created.
- static UI_DEVTOOLS_EXPORT std::unique_ptr<UiDevToolsServer> Create(
+ static std::unique_ptr<UiDevToolsServer> Create(
scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner);
// Returns a list of attached UiDevToolsClient name + URL
using NameUrlPair = std::pair<std::string, std::string>;
- static UI_DEVTOOLS_EXPORT std::vector<NameUrlPair> GetClientNamesAndUrls();
+ static std::vector<NameUrlPair> GetClientNamesAndUrls();
void AttachClient(std::unique_ptr<UiDevToolsClient> client);
void SendOverWebSocket(int connection_id, const String& message);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698