Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2567983005: [Offline Pages] Fix test harness failure related with batch size. (Closed)

Created:
4 years ago by romax
Modified:
3 years, 9 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Fix test harness failure related with batch size. Fixed the test failure due to not setting default batch size in script. BUG=673519 Committed: https://crrev.com/3ab9aa8520f4cbd52f2b03af4880464cbfa23324 Cr-Commit-Position: refs/heads/master@{#438032}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java View 1 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/run_offline_page_evaluation_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
romax
PTAL, thanks!
4 years ago (2016-12-13 01:00:28 UTC) #2
Pete Williamson
https://codereview.chromium.org/2567983005/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java (right): https://codereview.chromium.org/2567983005/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java#newcode123 chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java:123: return; An ASSERT here would be nice.
4 years ago (2016-12-13 01:21:15 UTC) #3
romax
addressed comment, PTAL.
4 years ago (2016-12-13 01:32:04 UTC) #4
Pete Williamson
lgtm
4 years ago (2016-12-13 01:37:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567983005/20001
4 years ago (2016-12-13 02:45:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 03:37:49 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 03:41:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ab9aa8520f4cbd52f2b03af4880464cbfa23324
Cr-Commit-Position: refs/heads/master@{#438032}

Powered by Google App Engine
This is Rietveld 408576698