Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java

Issue 2567983005: [Offline Pages] Fix test harness failure related with batch size. (Closed)
Patch Set: comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/evaluation/run_offline_page_evaluation_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
index 5382500ad6f4c0d347ae8a2d1093ed61e130891e..c7f087ee005d58f414249ca626eaa3d2718ae00d 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java
@@ -119,6 +119,7 @@ public class OfflinePageSavePageLaterEvaluationTest
ThreadUtils.runOnUiThread(new Runnable() {
@Override
public void run() {
+ assert mBridge != null;
mBridge.getRequestsInQueue(new Callback<SavePageRequest[]>() {
@Override
public void onResult(SavePageRequest[] results) {
@@ -481,6 +482,9 @@ public class OfflinePageSavePageLaterEvaluationTest
Log.e(TAG, e.getMessage(), e);
fail(String.format(
"Config file %s is not found, aborting the test.", CONFIG_FILE_PATH));
+ } catch (NumberFormatException e) {
+ Log.e(TAG, e.getMessage(), e);
+ fail("Error parsing config file, aborting test.");
} finally {
if (inputStream != null) {
inputStream.close();
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/evaluation/run_offline_page_evaluation_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698