Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2567983002: Hook up REWRITE_FLOAT_UNARY_MINUS_OPERATOR workaround in ANGLE (Closed)

Created:
4 years ago by qiankun
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up REWRITE_FLOAT_UNARY_MINUS_OPERATOR workaround in ANGLE ANGLE CL is at: https://chromium-review.googlesource.com/#/c/417169. BUG=672380 TEST=conformance/glsl/bugs/unary-minus-operator-float-bug.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Committed: https://crrev.com/cc07fe9671a50758809aef07cb7fdbc7ca7c4e3f Cr-Commit-Position: refs/heads/master@{#438287}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +17 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
qiankun
PTAL.
4 years ago (2016-12-13 08:37:02 UTC) #4
Zhenyao Mo
On 2016/12/13 08:37:02, qiankun wrote: > PTAL. lgtm
4 years ago (2016-12-13 19:23:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567983002/1
4 years ago (2016-12-13 19:24:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 21:41:52 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 21:43:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc07fe9671a50758809aef07cb7fdbc7ca7c4e3f
Cr-Commit-Position: refs/heads/master@{#438287}

Powered by Google App Engine
This is Rietveld 408576698