Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2567853002: Clarify how LayoutSVGResourceMarker's m_viewport interacts with refX/refY (Closed)

Created:
4 years ago by pdr.
Modified:
4 years ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify how LayoutSVGResourceMarker's m_viewport interacts with refX/refY Because refX and refY are in the coordinate space of each marker instance, they are included in markerTransformation() instead of being part of the marker viewport. As a result, only a viewport size is maintained in LayoutSVGResourceMarker. This patch makes this distinction a little clearer by refactoring m_viewport to m_viewportSize, as well as adding some comments. No new tests; no change in behavior. Committed: https://crrev.com/db41bb454ddbdd14f8187e50638b64d290d64ccd Cr-Commit-Position: refs/heads/master@{#437803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp View 4 chunks +8 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
pdr.
4 years ago (2016-12-10 06:35:12 UTC) #4
fs
lgtm
4 years ago (2016-12-10 09:12:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567853002/1
4 years ago (2016-12-11 18:48:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-11 20:45:45 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 15:10:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db41bb454ddbdd14f8187e50638b64d290d64ccd
Cr-Commit-Position: refs/heads/master@{#437803}

Powered by Google App Engine
This is Rietveld 408576698