Add support for caching and invalidating SVG marker transforms

Add support for caching and invalidating SVG marker transforms

This patch adds a cache of the SVG marker transform, similar to the pattern
used in LayoutSVGViewportContainer. This should be a small perf win because
we no longer re-calculate the transform when painting each marker instance.
With this new cache logic, invalidation logic has been added which includes
a fix for paint property under-invalidation (marker-viewBox-changes.svg).

BUG=645667, 600618
Committed: https://crrev.com/d798a7a82ead340d6206380d64e310c222416e62
Cr-Commit-Position: refs/heads/master@{#437993}

[pdr., 2016-12-10 06:27:12]

Description was changed from

==========
Add support for caching and invalidating SVG marker transforms

This patch adds a cache of the SVG marker transform, similar to the pattern
used in LayoutSVGViewportContainer. This should be a small perf win because
we no longer re-calculate the transform when painting each marker instance.
With this new cache logic, invalidation logic has been added which includes
a fix for paint property under-invalidation (marker-viewBox-changes.svg).

BUG=645667, 600618
==========

to

==========
Add support for caching and invalidating SVG marker transforms

This patch adds a cache of the SVG marker transform, similar to the pattern
used in LayoutSVGViewportContainer. This should be a small perf win because
we no longer re-calculate the transform when painting each marker instance.
With this new cache logic, invalidation logic has been added which includes
a fix for paint property under-invalidation (marker-viewBox-changes.svg).

BUG=645667,600618
==========

[pdr., 2016-12-10 06:27:16]

pdr@chromium.org changed reviewers:
+ fs@opera.com

[pdr., 2016-12-10 06:27:28]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 06:27:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 06:29:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 06:29:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fs, 2016-12-10 09:33:12]

lgtm

https://codereview.chromium.org/2565943002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
(left):

https://codereview.chromium.org/2565943002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp:144: void
LayoutSVGResourceMarker::calcViewport() {
(Maybe we should consider performing this folding operation - calcViewport into
calculateLocalTransform - in LayoutSVGViewportContainer too.)

[pdr., 2016-12-12 18:33:36]

On 2016/12/10 at 09:33:12, fs wrote:
> lgtm
> 
>
https://codereview.chromium.org/2565943002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp
(left):
> 
>
https://codereview.chromium.org/2565943002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMarker.cpp:144:
void LayoutSVGResourceMarker::calcViewport() {
> (Maybe we should consider performing this folding operation - calcViewport
into calculateLocalTransform - in LayoutSVGViewportContainer too.)

Thanks!

I agree, and will do that as a followup today

[pdr., 2016-12-12 18:33:52]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-12-12 18:34:12]

The CQ bit was unchecked by pdr@chromium.org

[pdr., 2016-12-12 18:38:50]

The CQ bit was checked by pdr@chromium.org

[pdr., 2016-12-12 18:38:51]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2565943002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-12 18:39:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:54:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:54:39]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pdr., 2016-12-13 00:44:00]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:45:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:35:51]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481589840436890,
"parent_rev": "3ef259598d3d17291c38ea0c72c31c410153a063", "commit_rev":
"bedecbc6b65901dca742e2054225aa8464f0ee08"}

[commit-bot: I haz the power, 2016-12-13 02:36:26]

Description was changed from

==========
Add support for caching and invalidating SVG marker transforms

This patch adds a cache of the SVG marker transform, similar to the pattern
used in LayoutSVGViewportContainer. This should be a small perf win because
we no longer re-calculate the transform when painting each marker instance.
With this new cache logic, invalidation logic has been added which includes
a fix for paint property under-invalidation (marker-viewBox-changes.svg).

BUG=645667,600618
==========

to

==========
Add support for caching and invalidating SVG marker transforms

This patch adds a cache of the SVG marker transform, similar to the pattern
used in LayoutSVGViewportContainer. This should be a small perf win because
we no longer re-calculate the transform when painting each marker instance.
With this new cache logic, invalidation logic has been added which includes
a fix for paint property under-invalidation (marker-viewBox-changes.svg).

BUG=645667,600618

Review-Url: https://codereview.chromium.org/2565943002
==========

[commit-bot: I haz the power, 2016-12-13 02:36:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-13 02:39:58]

Description was changed from

==========
Add support for caching and invalidating SVG marker transforms

This patch adds a cache of the SVG marker transform, similar to the pattern
used in LayoutSVGViewportContainer. This should be a small perf win because
we no longer re-calculate the transform when painting each marker instance.
With this new cache logic, invalidation logic has been added which includes
a fix for paint property under-invalidation (marker-viewBox-changes.svg).

BUG=645667,600618

Review-Url: https://codereview.chromium.org/2565943002
==========

to

==========
Add support for caching and invalidating SVG marker transforms

This patch adds a cache of the SVG marker transform, similar to the pattern
used in LayoutSVGViewportContainer. This should be a small perf win because
we no longer re-calculate the transform when painting each marker instance.
With this new cache logic, invalidation logic has been added which includes
a fix for paint property under-invalidation (marker-viewBox-changes.svg).

BUG=645667,600618

Committed: https://crrev.com/d798a7a82ead340d6206380d64e310c222416e62
Cr-Commit-Position: refs/heads/master@{#437993}
==========

[commit-bot: I haz the power, 2016-12-13 02:39:59]

Patchset 4 (id:??) landed as
https://crrev.com/d798a7a82ead340d6206380d64e310c222416e62
Cr-Commit-Position: refs/heads/master@{#437993}