Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655

Committed: https://crrev.com/2ae3356d5aea96c53704adabd1804336c176571b
Cr-Commit-Position: refs/heads/master@{#438039}

[ke.he, 2016-12-10 05:48:21]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 05:48:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 06:42:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 06:42:57]

Dry run: This issue passed the CQ dry run.

[ke.he, 2016-12-10 06:49:42]

ke.he@intel.com changed reviewers:
+ blundell@chromium.org

[ke.he, 2016-12-10 06:49:42]

Hi, blundell@, We left a TODO() said that in renderer side
GamepadSharedBufferImpl can use mojo::SharedBuffer to replace
base::SharedMemory.

PTAL. Thanks. 

By the way, I'll start to look another TODO() we left soon.

[blundell, 2016-12-12 12:40:21]

lgtm

[ke.he, 2016-12-12 12:45:41]

ke.he@intel.com changed reviewers:
+ jam@chromium.org

[ke.he, 2016-12-12 12:45:41]

jam@, Could you please PTAL on this. Thanks!

[jam, 2016-12-12 17:56:48]

lgtm

[ke.he, 2016-12-13 02:22:42]

The CQ bit was checked by ke.he@intel.com

[commit-bot: I haz the power, 2016-12-13 02:23:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ke.he, 2016-12-13 02:35:41]

Description was changed from

==========
Using mojo::ScopedSharedBufferHandle directly in GamepadSharedBufferImpl

After gamepad mojoification, In renderer side, GamepadSharedBufferImpl has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedBufferImpl completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655
==========

to

==========
Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655
==========

[ke.he, 2016-12-13 02:36:39]

Description was changed from

==========
Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655
==========

to

==========
Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655
==========

[commit-bot: I haz the power, 2016-12-13 03:44:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481595762721950, "parent_rev":
"e625d5d127857c8474acc165d99a6b689e0f7965", "commit_rev":
"29f85177c012fa3b35ef3dacf59279f7e9e1431b"}

[commit-bot: I haz the power, 2016-12-13 03:45:14]

Description was changed from

==========
Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655
==========

to

==========
Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655

Review-Url: https://codereview.chromium.org/2567713003
==========

[commit-bot: I haz the power, 2016-12-13 03:45:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 03:49:16]

Description was changed from

==========
Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655

Review-Url: https://codereview.chromium.org/2567713003
==========

to

==========
Using mojo::ScopedSharedBufferHandle directly in GamepadSharedMemoryReader

After gamepad mojoification, In renderer side, GamepadSharedMemoryReader has to
"unwrap" the received mojo::ScopedSharedBufferHandle into a
base::SharedMemoryHandle. It is not good.

In this patch we let GamepadSharedMemoryReader completely use mojo::SharedBuffer
to avoid the "unwrap" operation.

BUG = 670655

Committed: https://crrev.com/2ae3356d5aea96c53704adabd1804336c176571b
Cr-Commit-Position: refs/heads/master@{#438039}
==========

[commit-bot: I haz the power, 2016-12-13 03:49:17]

Patchset 1 (id:??) landed as
https://crrev.com/2ae3356d5aea96c53704adabd1804336c176571b
Cr-Commit-Position: refs/heads/master@{#438039}