IDL compiler: remove nop return from end of getters and setters

IDL compiler: remove nop return from end of getters and setters

Getters and setters are void functions.
Currently they end with a useless return; this removes them.

BUG=239771
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158695

[haraken, 2013-10-02 03:52:58]

LGTM

[commit-bot: I haz the power, 2013-10-02 04:00:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/25675003/1

[commit-bot: I haz the power, 2013-10-02 05:43:41]

Retried try job too often on win_blink_rel for step(s) webkit_lint,
webkit_python_tests, webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-02 05:54:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/25675003/1

[commit-bot: I haz the power, 2013-10-02 05:54:54]

Failed to apply patch for Source/bindings/tests/results/V8TestObjectPython.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestObjectPython.cpp
  Hunk #1 succeeded at 78 (offset 1 line).
  Hunk #2 succeeded at 119 (offset 29 lines).
  Hunk #3 succeeded at 132 (offset 29 lines).
  Hunk #4 succeeded at 145 (offset 29 lines).
  Hunk #5 succeeded at 158 (offset 29 lines).
  Hunk #6 succeeded at 171 (offset 29 lines).
  Hunk #7 succeeded at 184 (offset 29 lines).
  Hunk #8 succeeded at 197 (offset 29 lines).
  Hunk #9 succeeded at 210 (offset 29 lines).
  Hunk #10 succeeded at 223 (offset 29 lines).
  Hunk #11 succeeded at 236 (offset 29 lines).
  Hunk #12 succeeded at 249 (offset 29 lines).
  Hunk #13 FAILED at 233.
  Hunk #14 FAILED at 247.
  Hunk #15 succeeded at 276 (offset 15 lines).
  Hunk #16 succeeded at 289 (offset 15 lines).
  Hunk #17 succeeded at 302 (offset 15 lines).
  Hunk #18 succeeded at 315 (offset 15 lines).
  Hunk #19 succeeded at 328 (offset 15 lines).
  Hunk #20 succeeded at 341 (offset 15 lines).
  Hunk #21 succeeded at 354 (offset 15 lines).
  Hunk #22 succeeded at 367 (offset 15 lines).
  Hunk #23 succeeded at 380 (offset 15 lines).
  Hunk #24 succeeded at 393 (offset 15 lines).
  Hunk #25 succeeded at 406 (offset 15 lines).
  Hunk #26 succeeded at 419 (offset 15 lines).
  Hunk #27 succeeded at 432 (offset 15 lines).
  Hunk #28 succeeded at 445 (offset 15 lines).
  Hunk #29 succeeded at 506 (offset 57 lines).
  Hunk #30 succeeded at 525 (offset 57 lines).
  Hunk #31 succeeded at 537 (offset 57 lines).
  Hunk #32 succeeded at 549 (offset 57 lines).
  2 out of 32 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestObjectPython.cpp.rej

Patch:       Source/bindings/tests/results/V8TestObjectPython.cpp
Index: Source/bindings/tests/results/V8TestObjectPython.cpp
diff --git a/Source/bindings/tests/results/V8TestObjectPython.cpp
b/Source/bindings/tests/results/V8TestObjectPython.cpp
index
d4011cb6d5c77f42aa7cbde3caf97ee0c3adee32..84d7ece6ac1929fa4118042eca41444351f5b98e
100644
--- a/Source/bindings/tests/results/V8TestObjectPython.cpp
+++ b/Source/bindings/tests/results/V8TestObjectPython.cpp
@@ -77,7 +77,6 @@ static void
readonlyDateAttributeAttributeGetter(v8::Local<v8::String> name, con
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValue(info, v8DateOrNull(imp->readonlyDateAttribute(),
info.GetIsolate()));
-    return;
 }
 
 static void readonlyDateAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -91,7 +90,6 @@ static void
readonlyBooleanAttributeAttributeGetter(v8::Local<v8::String> name,
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueBool(info, imp->readonlyBooleanAttribute());
-    return;
 }
 
 static void
readonlyBooleanAttributeAttributeGetterCallback(v8::Local<v8::String> name,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -105,7 +103,6 @@ static void
readonlyByteAttributeAttributeGetter(v8::Local<v8::String> name, con
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueInt(info, imp->readonlyByteAttribute());
-    return;
 }
 
 static void readonlyByteAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -119,7 +116,6 @@ static void
readonlyDoubleAttributeAttributeGetter(v8::Local<v8::String> name, c
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValue(info, imp->readonlyDoubleAttribute());
-    return;
 }
 
 static void
readonlyDoubleAttributeAttributeGetterCallback(v8::Local<v8::String> name, const
v8::PropertyCallbackInfo<v8::Value>& info)
@@ -133,7 +129,6 @@ static void
readonlyFloatAttributeAttributeGetter(v8::Local<v8::String> name, co
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValue(info, imp->readonlyFloatAttribute());
-    return;
 }
 
 static void readonlyFloatAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -147,7 +142,6 @@ static void
readonlyLongAttributeAttributeGetter(v8::Local<v8::String> name, con
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueInt(info, imp->readonlyLongAttribute());
-    return;
 }
 
 static void readonlyLongAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -161,7 +155,6 @@ static void
readonlyLongLongAttributeAttributeGetter(v8::Local<v8::String> name,
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValue(info,
static_cast<double>(imp->readonlyLongLongAttribute()));
-    return;
 }
 
 static void
readonlyLongLongAttributeAttributeGetterCallback(v8::Local<v8::String> name,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -175,7 +168,6 @@ static void
readonlyOctetAttributeAttributeGetter(v8::Local<v8::String> name, co
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueUnsigned(info, imp->readonlyOctetAttribute());
-    return;
 }
 
 static void readonlyOctetAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -189,7 +181,6 @@ static void
readonlyShortAttributeAttributeGetter(v8::Local<v8::String> name, co
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueInt(info, imp->readonlyShortAttribute());
-    return;
 }
 
 static void readonlyShortAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -203,7 +194,6 @@ static void
readonlyUnsignedLongAttributeAttributeGetter(v8::Local<v8::String> n
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueUnsigned(info, imp->readonlyUnsignedLongAttribute());
-    return;
 }
 
 static void
readonlyUnsignedLongAttributeAttributeGetterCallback(v8::Local<v8::String> name,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -217,7 +207,6 @@ static void
readonlyUnsignedLongLongAttributeAttributeGetter(v8::Local<v8::Strin
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValue(info,
static_cast<double>(imp->readonlyUnsignedLongLongAttribute()));
-    return;
 }
 
 static void
readonlyUnsignedLongLongAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -231,7 +220,6 @@ static void
readonlyUnsignedShortAttributeAttributeGetter(v8::Local<v8::String>
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueUnsigned(info, imp->readonlyUnsignedShortAttribute());
-    return;
 }
 
 static void
readonlyUnsignedShortAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -245,7 +233,6 @@ static void
readonlyStringAttributeAttributeGetter(v8::Local<v8::String> name, c
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueString(info, imp->readonlyStringAttribute(),
info.GetIsolate());
-    return;
 }
 
 static void
readonlyStringAttributeAttributeGetterCallback(v8::Local<v8::String> name, const
v8::PropertyCallbackInfo<v8::Value>& info)
@@ -259,7 +246,6 @@ static void
readonlyDOMTimeStampAttributeAttributeGetter(v8::Local<v8::String> n
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValue(info,
static_cast<double>(imp->readonlyDOMTimeStampAttribute()));
-    return;
 }
 
 static void
readonlyDOMTimeStampAttributeAttributeGetterCallback(v8::Local<v8::String> name,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -273,7 +259,6 @@ static void
readonlySerializedScriptValueAttributeAttributeGetter(v8::Local<v8::
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValue(info, imp->readonlySerializedScriptValueAttribute() ?
imp->readonlySerializedScriptValueAttribute()->deserialize() :
v8::Handle<v8::Value>(v8::Null(info.GetIsolate())));
-    return;
 }
 
 static void
readonlySerializedScriptValueAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -287,7 +272,6 @@ static void
readonlyAnyAttributeAttributeGetter(v8::Local<v8::String> name, cons
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValue(info, imp->readonlyAnyAttribute().v8Value());
-    return;
 }
 
 static void readonlyAnyAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -301,7 +285,6 @@ static void
readonlyDocumentAttributeAttributeGetter(v8::Local<v8::String> name,
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueFast(info, imp->readonlyDocumentAttribute(), imp);
-    return;
 }
 
 static void
readonlyDocumentAttributeAttributeGetterCallback(v8::Local<v8::String> name,
const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -315,7 +298,6 @@ static void
readonlyDocumentFragmentAttributeAttributeGetter(v8::Local<v8::Strin
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueFast(info, imp->readonlyDocumentFragmentAttribute(), imp);
-    return;
 }
 
 static void
readonlyDocumentFragmentAttributeAttributeGetterCallback(v8::Local<v8::String>
name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -329,7 +311,6 @@ static void
readonlyDocumentTypeAttributeAttributeGetter(v8::Local<v8::String> n
 {
     TestObjectPython* imp = V8TestObjectPython::toNative(info.Holder());
     v8SetReturnValueFast(info, imp->readonlyDocumentTypeAttribute(), imp);
-  …
(message too large)

[commit-bot: I haz the power, 2013-10-02 05:57:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nbarth@chromium.org/25675003/16001

[commit-bot: I haz the power, 2013-10-02 07:38:54]

Change committed as 158695