Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: Source/bindings/tests/results/V8TestTypedefs.cpp

Issue 25675003: IDL compiler: remove nop return from end of getters and setters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestTypedefs.cpp
diff --git a/Source/bindings/tests/results/V8TestTypedefs.cpp b/Source/bindings/tests/results/V8TestTypedefs.cpp
index 9cc2115f1cb9b82bd54f802efe450b6d4dad4a58..068cbfc3bcf555dd168926ce16cf346533d7c84e 100644
--- a/Source/bindings/tests/results/V8TestTypedefs.cpp
+++ b/Source/bindings/tests/results/V8TestTypedefs.cpp
@@ -72,7 +72,6 @@ static void unsignedLongLongAttrAttributeGetter(v8::Local<v8::String> name, cons
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
v8SetReturnValue(info, static_cast<double>(imp->unsignedLongLongAttr()));
- return;
}
static void unsignedLongLongAttrAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -87,7 +86,6 @@ static void unsignedLongLongAttrAttributeSetter(v8::Local<v8::String> name, v8::
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
V8TRYCATCH_VOID(unsigned long long, v, toUInt64(value));
imp->setUnsignedLongLongAttr(v);
- return;
}
static void unsignedLongLongAttrAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
@@ -101,7 +99,6 @@ static void immutableSerializedScriptValueAttributeGetter(v8::Local<v8::String>
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
v8SetReturnValue(info, imp->immutableSerializedScriptValue() ? imp->immutableSerializedScriptValue()->deserialize() : v8::Handle<v8::Value>(v8::Null(info.GetIsolate())));
- return;
}
static void immutableSerializedScriptValueAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -116,7 +113,6 @@ static void immutableSerializedScriptValueAttributeSetter(v8::Local<v8::String>
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
V8TRYCATCH_VOID(RefPtr<SerializedScriptValue>, v, SerializedScriptValue::create(value, info.GetIsolate()));
imp->setImmutableSerializedScriptValue(WTF::getPtr(v));
- return;
}
static void immutableSerializedScriptValueAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
@@ -134,7 +130,6 @@ static void attrWithGetterExceptionAttributeGetter(v8::Local<v8::String> name, c
if (UNLIKELY(es.throwIfNeeded()))
return;
v8SetReturnValueInt(info, value);
- return;
}
static void attrWithGetterExceptionAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -149,7 +144,6 @@ static void attrWithGetterExceptionAttributeSetter(v8::Local<v8::String> name, v
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
V8TRYCATCH_VOID(int, v, toInt32(value));
imp->setAttrWithGetterException(v);
- return;
}
static void attrWithGetterExceptionAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
@@ -163,7 +157,6 @@ static void attrWithSetterExceptionAttributeGetter(v8::Local<v8::String> name, c
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
v8SetReturnValueInt(info, imp->attrWithSetterException());
- return;
}
static void attrWithSetterExceptionAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -180,7 +173,6 @@ static void attrWithSetterExceptionAttributeSetter(v8::Local<v8::String> name, v
ExceptionState es(info.GetIsolate());
imp->setAttrWithSetterException(v, es);
es.throwIfNeeded();
- return;
}
static void attrWithSetterExceptionAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
@@ -198,7 +190,6 @@ static void stringAttrWithGetterExceptionAttributeGetter(v8::Local<v8::String> n
if (UNLIKELY(es.throwIfNeeded()))
return;
v8SetReturnValueString(info, value, info.GetIsolate());
- return;
}
static void stringAttrWithGetterExceptionAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -213,7 +204,6 @@ static void stringAttrWithGetterExceptionAttributeSetter(v8::Local<v8::String> n
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, v, value);
imp->setStringAttrWithGetterException(v);
- return;
}
static void stringAttrWithGetterExceptionAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
@@ -227,7 +217,6 @@ static void stringAttrWithSetterExceptionAttributeGetter(v8::Local<v8::String> n
{
TestTypedefs* imp = V8TestTypedefs::toNative(info.Holder());
v8SetReturnValueString(info, imp->stringAttrWithSetterException(), info.GetIsolate());
- return;
}
static void stringAttrWithSetterExceptionAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -244,7 +233,6 @@ static void stringAttrWithSetterExceptionAttributeSetter(v8::Local<v8::String> n
ExceptionState es(info.GetIsolate());
imp->setStringAttrWithSetterException(v, es);
es.throwIfNeeded();
- return;
}
static void stringAttrWithSetterExceptionAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
« no previous file with comments | « Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698