Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp

Issue 25675003: IDL compiler: remove nop return from end of getters and setters (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp b/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
index 4c9c335d8d189c9349805a99f5ce0662061ef295..b3d500fca6b74c71e3baa2490b6c03647a1c9811 100644
--- a/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
@@ -67,7 +67,6 @@ static void aAttributeGetter(v8::Local<v8::String> name, const v8::PropertyCallb
{
RealClass* imp = V8TestInterfaceImplementedAs::toNative(info.Holder());
v8SetReturnValueString(info, imp->a(), info.GetIsolate());
- return;
}
static void aAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -82,7 +81,6 @@ static void aAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> va
RealClass* imp = V8TestInterfaceImplementedAs::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, v, value);
imp->setA(v);
- return;
}
static void aAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
@@ -96,7 +94,6 @@ static void bAttributeGetter(v8::Local<v8::String> name, const v8::PropertyCallb
{
RealClass* imp = V8TestInterfaceImplementedAs::toNative(info.Holder());
v8SetReturnValueFast(info, imp->b(), imp);
- return;
}
static void bAttributeGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -111,7 +108,6 @@ static void bAttributeSetter(v8::Local<v8::String> name, v8::Local<v8::Value> va
RealClass* imp = V8TestInterfaceImplementedAs::toNative(info.Holder());
V8TRYCATCH_VOID(RealClass*, v, V8TestInterfaceImplementedAs::HasInstance(value, info.GetIsolate(), worldType(info.GetIsolate())) ? V8TestInterfaceImplementedAs::toNative(v8::Handle<v8::Object>::Cast(value)) : 0);
imp->setB(WTF::getPtr(v));
- return;
}
static void bAttributeSetterCallback(v8::Local<v8::String> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info)
« no previous file with comments | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698