DevTools: drastically simplify UISourceCode.checkContentUpdated

DevTools: drastically simplify UISourceCode.checkContentUpdated

As a part of "Persistence" plan, the UISourceCode.checkContentUpdated
method should move away from UISourceCode.

This CL is a preparation for this. This patch kills a few clients of the
method, since they are not needed any more:
1. SourcesSearchScope shouldn't be forcing checkContentUpdated during search,
   it can simply request content
2. The UISourceCodeFrame shouldn't request content on focus - the iNotify
   reports changes while devtools are blurred.

BUG=673086
R=dgozman

Committed: https://crrev.com/29f641736f1abdbd30ba57cd036774d5801bb236
Cr-Commit-Position: refs/heads/master@{#438772}

[lushnikov, 2016-12-13 19:24:55]

please, take a look

[lushnikov, 2016-12-14 20:13:35]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 20:14:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 21:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 21:40:29]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dgozman, 2016-12-14 22:45:00]

lgtm

[lushnikov, 2016-12-15 00:37:27]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 00:38:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-12-15 00:44:00]

FYI: killed a test which was checking a proper use of "checkContentUpdated" on
snippet uisourcecodes. This never happens any more with this patch.

[lushnikov, 2016-12-15 00:44:06]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-15 00:44:07]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2567283004/#ps40001
(title: "kill stale test")

[commit-bot: I haz the power, 2016-12-15 00:44:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:51:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:51:52]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[lushnikov, 2016-12-15 05:50:24]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-12-15 05:50:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 07:08:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481781024825040,
"parent_rev": "f242e4bc5f2cea60f8b12a1eeed3828432765397", "commit_rev":
"e693441709991ab3ea222d4f9af88b644698e938"}

[commit-bot: I haz the power, 2016-12-15 07:08:42]

Description was changed from

==========
DevTools: drastically simplify UISourceCode.checkContentUpdated

As a part of "Persistence" plan, the UISourceCode.checkContentUpdated
method should move away from UISourceCode.

This CL is a preparation for this. This patch kills a few clients of the
method, since they are not needed any more:
1. SourcesSearchScope shouldn't be forcing checkContentUpdated during search,
   it can simply request content
2. The UISourceCodeFrame shouldn't request content on focus - the iNotify
   reports changes while devtools are blurred.

BUG=673086
R=dgozman
==========

to

==========
DevTools: drastically simplify UISourceCode.checkContentUpdated

As a part of "Persistence" plan, the UISourceCode.checkContentUpdated
method should move away from UISourceCode.

This CL is a preparation for this. This patch kills a few clients of the
method, since they are not needed any more:
1. SourcesSearchScope shouldn't be forcing checkContentUpdated during search,
   it can simply request content
2. The UISourceCodeFrame shouldn't request content on focus - the iNotify
   reports changes while devtools are blurred.

BUG=673086
R=dgozman

Review-Url: https://codereview.chromium.org/2567283004
==========

[commit-bot: I haz the power, 2016-12-15 07:08:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 07:11:17]

Description was changed from

==========
DevTools: drastically simplify UISourceCode.checkContentUpdated

As a part of "Persistence" plan, the UISourceCode.checkContentUpdated
method should move away from UISourceCode.

This CL is a preparation for this. This patch kills a few clients of the
method, since they are not needed any more:
1. SourcesSearchScope shouldn't be forcing checkContentUpdated during search,
   it can simply request content
2. The UISourceCodeFrame shouldn't request content on focus - the iNotify
   reports changes while devtools are blurred.

BUG=673086
R=dgozman

Review-Url: https://codereview.chromium.org/2567283004
==========

to

==========
DevTools: drastically simplify UISourceCode.checkContentUpdated

As a part of "Persistence" plan, the UISourceCode.checkContentUpdated
method should move away from UISourceCode.

This CL is a preparation for this. This patch kills a few clients of the
method, since they are not needed any more:
1. SourcesSearchScope shouldn't be forcing checkContentUpdated during search,
   it can simply request content
2. The UISourceCodeFrame shouldn't request content on focus - the iNotify
   reports changes while devtools are blurred.

BUG=673086
R=dgozman

Committed: https://crrev.com/29f641736f1abdbd30ba57cd036774d5801bb236
Cr-Commit-Position: refs/heads/master@{#438772}
==========

[commit-bot: I haz the power, 2016-12-15 07:11:18]

Patchset 3 (id:??) landed as
https://crrev.com/29f641736f1abdbd30ba57cd036774d5801bb236
Cr-Commit-Position: refs/heads/master@{#438772}