third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js - Issue 2567283004: DevTools: drastically simplify UISourceCode.checkContentUpdated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

Issue 2567283004: DevTools: drastically simplify UISourceCode.checkContentUpdated (Closed)

Patch Set: kill stale test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-checkContent-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

index 3ff033108c25dea2497d31b1acf695a595943ec8..641d357201eb8f158d168a1d85edd6c3b9882829 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js

@@ -222,15 +222,7 @@ Sources.SourcesSearchScope = class {

if (uiSourceCode.isDirty())

contentLoaded.call(this, uiSourceCode, uiSourceCode.workingCopy());

else

- uiSourceCode.checkContentUpdated(true, contentUpdated.bind(this, uiSourceCode));

- }

- /**

- * @param {!Workspace.UISourceCode} uiSourceCode

- * @this {Sources.SourcesSearchScope}

- */

- function contentUpdated(uiSourceCode) {

- uiSourceCode.requestContent().then(contentLoaded.bind(this, uiSourceCode));

+ uiSourceCode.requestContent().then(contentLoaded.bind(this, uiSourceCode));

}

/**