[ObjC ARC] Converts ios/chrome/browser:browser to ARC.

[ObjC ARC] Converts ios/chrome/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Committed: https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e
Cr-Commit-Position: refs/heads/master@{#438164}

[stkhapugin, 2016-12-12 15:00:50]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 15:01:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2016-12-12 15:53:21]

stkhapugin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[stkhapugin, 2016-12-12 15:53:22]

PTAL. Unfortunately I cannot test against the downstream bots (crbug.com/673354)
right now.

[commit-bot: I haz the power, 2016-12-12 16:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 16:16:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[sdefresne, 2016-12-12 19:37:01]

lgtm

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/app_star...
File ios/chrome/browser/app_startup_parameters.mm (right):

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/app_star...
ios/chrome/browser/app_startup_parameters.mm:31: -
(XCallbackParameters*)xCallbackParameters {
You can synthesize this property:

@synthesize xCallbackParameters = _xCallbackParameters;

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/app_star...
ios/chrome/browser/app_startup_parameters.mm:48: _externalURL =
GURL(externalURL);
nit: no need to invoke a copy constructor here, just assign

  _externalURL = externalURL;

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/root_coo...
File ios/chrome/browser/root_coordinator.mm (right):

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/root_coo...
ios/chrome/browser/root_coordinator.mm:14: __weak UIWindow* _window;
I think you can synthesize this property.

@synthesize window = _window;

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/xcallbac...
File ios/chrome/browser/xcallback_parameters.mm (right):

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/xcallbac...
ios/chrome/browser/xcallback_parameters.mm:16: NSString* _sourceAppId;
This can probably be synthesized too.

[sdefresne, 2016-12-12 19:37:16]

Comments can be addressed as followup CLs.

[stkhapugin, 2016-12-13 13:31:11]

Thank you!

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/app_star...
File ios/chrome/browser/app_startup_parameters.mm (right):

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/app_star...
ios/chrome/browser/app_startup_parameters.mm:31: -
(XCallbackParameters*)xCallbackParameters {
On 2016/12/12 19:37:00, sdefresne wrote:
> You can synthesize this property:
> 
> @synthesize xCallbackParameters = _xCallbackParameters;

Done.

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/app_star...
ios/chrome/browser/app_startup_parameters.mm:48: _externalURL =
GURL(externalURL);
On 2016/12/12 19:37:00, sdefresne wrote:
> nit: no need to invoke a copy constructor here, just assign
> 
>   _externalURL = externalURL;

Done.

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/root_coo...
File ios/chrome/browser/root_coordinator.mm (right):

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/root_coo...
ios/chrome/browser/root_coordinator.mm:14: __weak UIWindow* _window;
On 2016/12/12 19:37:00, sdefresne wrote:
> I think you can synthesize this property.
> 
> @synthesize window = _window;

Done.

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/xcallbac...
File ios/chrome/browser/xcallback_parameters.mm (right):

https://codereview.chromium.org/2566993002/diff/1/ios/chrome/browser/xcallbac...
ios/chrome/browser/xcallback_parameters.mm:16: NSString* _sourceAppId;
On 2016/12/12 19:37:01, sdefresne wrote:
> This can probably be synthesized too.

Done.

[stkhapugin, 2016-12-13 13:31:15]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2016-12-13 13:31:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2566993002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2016-12-13 13:31:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 14:30:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481635875522080,
"parent_rev": "0c46ad776b6b9dd136bbacbbf564a88b17e8c16f", "commit_rev":
"6f4214f9b31f4580a3d98c29bf494244b5a2af8c"}

[commit-bot: I haz the power, 2016-12-13 14:31:29]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2566993002
==========

[commit-bot: I haz the power, 2016-12-13 14:31:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-13 14:34:50]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2566993002
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser:browser to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Committed: https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e
Cr-Commit-Position: refs/heads/master@{#438164}
==========

[commit-bot: I haz the power, 2016-12-13 14:34:51]

Patchset 2 (id:??) landed as
https://crrev.com/c1be17914535f9aacc2b54fc5f9b5a899d20350e
Cr-Commit-Position: refs/heads/master@{#438164}