Description was changed from
==========
Revert of Disable UI options that allow new tabs before FRE. (patchset #4
id:60001 of https://codereview.chromium.org/2559573002/ )
Reason for revert:
Appears to have broken clank builds, and its blocking M57 Dev release
Original issue's description:
> Disable UI options that allow new tabs before FRE.
>
> Prior to completing the FRE on Android, we should disallow
> UI options that allow creating new tabs in Chrome.
>
> This disables "Web Search" from the action mode menu and
> also the various "Open in X" menu options.
>
> BUG=671149
>
> Review-Url: https://codereview.chromium.org/2559573002TBR=yusufo@chromium.org,asvitkine@chromium.org,tedchoc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671149
==========
to
==========
Revert of Disable UI options that allow new tabs before FRE. (patchset #4
id:60001 of https://codereview.chromium.org/2559573002/ )
Reason for revert:
Appears to have broken clank builds, and its blocking M57 Dev release
http://crbug/673212
Original issue's description:
> Disable UI options that allow new tabs before FRE.
>
> Prior to completing the FRE on Android, we should disallow
> UI options that allow creating new tabs in Chrome.
>
> This disables "Web Search" from the action mode menu and
> also the various "Open in X" menu options.
>
> BUG=671149
>
> Review-Url: https://codereview.chromium.org/2559573002TBR=yusufo@chromium.org,asvitkine@chromium.org,tedchoc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671149
==========
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
Description was changed from
==========
Revert of Disable UI options that allow new tabs before FRE. (patchset #4
id:60001 of https://codereview.chromium.org/2559573002/ )
Reason for revert:
Appears to have broken clank builds, and its blocking M57 Dev release
http://crbug/673212
Original issue's description:
> Disable UI options that allow new tabs before FRE.
>
> Prior to completing the FRE on Android, we should disallow
> UI options that allow creating new tabs in Chrome.
>
> This disables "Web Search" from the action mode menu and
> also the various "Open in X" menu options.
>
> BUG=671149
>
> Review-Url: https://codereview.chromium.org/2559573002TBR=yusufo@chromium.org,asvitkine@chromium.org,tedchoc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671149
==========
to
==========
Revert of Disable UI options that allow new tabs before FRE. (patchset #4
id:60001 of https://codereview.chromium.org/2559573002/ )
Reason for revert:
Appears to have broken clank builds, and its blocking M57 Dev release
http://crbug/673212
Original issue's description:
> Disable UI options that allow new tabs before FRE.
>
> Prior to completing the FRE on Android, we should disallow
> UI options that allow creating new tabs in Chrome.
>
> This disables "Web Search" from the action mode menu and
> also the various "Open in X" menu options.
>
> BUG=671149
>
> Review-Url: https://codereview.chromium.org/2559573002TBR=yusufo@chromium.org,asvitkine@chromium.org,tedchoc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671149
Review-Url: https://codereview.chromium.org/2566963002
==========
Description was changed from
==========
Revert of Disable UI options that allow new tabs before FRE. (patchset #4
id:60001 of https://codereview.chromium.org/2559573002/ )
Reason for revert:
Appears to have broken clank builds, and its blocking M57 Dev release
http://crbug/673212
Original issue's description:
> Disable UI options that allow new tabs before FRE.
>
> Prior to completing the FRE on Android, we should disallow
> UI options that allow creating new tabs in Chrome.
>
> This disables "Web Search" from the action mode menu and
> also the various "Open in X" menu options.
>
> BUG=671149
>
> Review-Url: https://codereview.chromium.org/2559573002TBR=yusufo@chromium.org,asvitkine@chromium.org,tedchoc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671149
Review-Url: https://codereview.chromium.org/2566963002
==========
to
==========
Revert of Disable UI options that allow new tabs before FRE. (patchset #4
id:60001 of https://codereview.chromium.org/2559573002/ )
Reason for revert:
Appears to have broken clank builds, and its blocking M57 Dev release
http://crbug/673212
Original issue's description:
> Disable UI options that allow new tabs before FRE.
>
> Prior to completing the FRE on Android, we should disallow
> UI options that allow creating new tabs in Chrome.
>
> This disables "Web Search" from the action mode menu and
> also the various "Open in X" menu options.
>
> BUG=671149
>
> Review-Url: https://codereview.chromium.org/2559573002TBR=yusufo@chromium.org,asvitkine@chromium.org,tedchoc@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=671149
Committed: https://crrev.com/7b3fb254de09e691a4a884592f325f94ae8dd215
Cr-Commit-Position: refs/heads/master@{#437848}
==========
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7b3fb254de09e691a4a884592f325f94ae8dd215 Cr-Commit-Position: refs/heads/master@{#437848}
Issue 2566963002: Revert of Disable UI options that allow new tabs before FRE.
(Closed)
Created 4 years ago by perezju
Modified 4 years ago
Reviewers: Yusuf, Alexei Svitkine (slow), Ted C
Base URL:
Comments: 0