Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2566963002: Revert of Disable UI options that allow new tabs before FRE. (Closed)

Created:
4 years ago by perezju
Modified:
4 years ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable UI options that allow new tabs before FRE. (patchset #4 id:60001 of https://codereview.chromium.org/2559573002/ ) Reason for revert: Appears to have broken clank builds, and its blocking M57 Dev release http://crbug/673212 Original issue's description: > Disable UI options that allow new tabs before FRE. > > Prior to completing the FRE on Android, we should disallow > UI options that allow creating new tabs in Chrome. > > This disables "Web Search" from the action mode menu and > also the various "Open in X" menu options. > > BUG=671149 > > Review-Url: https://codereview.chromium.org/2559573002 TBR=yusufo@chromium.org,asvitkine@chromium.org,tedchoc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671149 Committed: https://crrev.com/7b3fb254de09e691a4a884592f325f94ae8dd215 Cr-Commit-Position: refs/heads/master@{#437848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -73 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActionModeCallback.java View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunStatus.java View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/LightweightFirstRunActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 4 chunks +1 line, -18 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/firstrun/FirstRunIntegrationTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/ContextMenuLoadUrlParamsTest.java View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
perezju
Created Revert of Disable UI options that allow new tabs before FRE.
4 years ago (2016-12-12 09:51:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566963002/1
4 years ago (2016-12-12 11:25:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 11:30:55 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b3fb254de09e691a4a884592f325f94ae8dd215
Cr-Commit-Position: refs/heads/master@{#437848}

Powered by Google App Engine
This is Rietveld 408576698