chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java - Issue 2566963002: Revert of Disable UI options that allow new tabs before FRE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Issue 2566963002: Revert of Disable UI options that allow new tabs before FRE. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/EmbedContentViewActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

index de05f0476f745fadfe1976616501b796222d4ad8..7b1f8a2a88a421793cf790bd4f10dc3835a0cc27 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

@@ -15,7 +15,6 @@

import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.firstrun.FirstRunStatus;

import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;

import org.chromium.chrome.browser.preferences.datareduction.DataReductionProxyUma;

import org.chromium.chrome.browser.search_engines.TemplateUrlService;

@@ -271,16 +270,6 @@

TemplateUrlService.getInstance()

.getDefaultSearchEngineTemplateUrl().getShortName()));

}

- }

- // Hide all items that could spawn additional tabs until FRE has been completed.

- if (!FirstRunStatus.getFirstRunFlowComplete()) {

- menu.findItem(R.id.contextmenu_open_image_in_new_tab).setVisible(false);

- menu.findItem(R.id.contextmenu_open_in_other_window).setVisible(false);

- menu.findItem(R.id.contextmenu_open_in_new_tab).setVisible(false);

- menu.findItem(R.id.contextmenu_open_in_incognito_tab).setVisible(false);

- menu.findItem(R.id.contextmenu_search_by_image).setVisible(false);

- menu.findItem(R.id.menu_id_open_in_chrome).setVisible(false);

}

if (mMode == FULLSCREEN_TAB_MODE) {