Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2566693004: Fix TestBrowserThreadBundle destruction order in IndexedDBDatabaseOperationTest. (Closed)

Created:
4 years ago by gab
Modified:
4 years ago
Reviewers:
cmumford
CC:
chromium-reviews, jam, jsbell+idb_chromium.org, darin-cc_chromium.org, michaeln
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix TestBrowserThreadBundle destruction order in IndexedDBDatabaseOperationTest. IndexedDBDatabase requires BrowserThread::IO to be alive when it is destroyed or it leaks some of its DeleteOnIOThread scoped_refptr members. Not doing so results in LSAN failures in https://codereview.chromium.org/2464233002 per it tightening TestBrowserThread's shutdown semantics. BUG=653916 Committed: https://crrev.com/9361390bd8a415b79cba242e70149bf6ca9a80ab Cr-Commit-Position: refs/heads/master@{#437899}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/indexed_db/indexed_db_database_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (15 generated)
gab
@michaeln PTAL and CQ if it LGTY, thanks!
4 years ago (2016-12-09 23:42:24 UTC) #4
gab
Oops, read OWNERS wrong, @cmumford for review (please CQ if LGTY)
4 years ago (2016-12-09 23:43:54 UTC) #7
cmumford
lgtm
4 years ago (2016-12-12 17:01:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566693004/20001
4 years ago (2016-12-12 17:02:12 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-12 18:05:34 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-12 18:21:35 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9361390bd8a415b79cba242e70149bf6ca9a80ab
Cr-Commit-Position: refs/heads/master@{#437899}

Powered by Google App Engine
This is Rietveld 408576698