|
|
Chromium Code Reviews
DescriptionFix TestBrowserThreadBundle destruction order in IndexedDBDatabaseOperationTest.
IndexedDBDatabase requires BrowserThread::IO to be alive when it is
destroyed or it leaks some of its DeleteOnIOThread scoped_refptr members.
Not doing so results in LSAN failures in
https://codereview.chromium.org/2464233002 per it tightening
TestBrowserThread's shutdown semantics.
BUG=653916
Committed: https://crrev.com/9361390bd8a415b79cba242e70149bf6ca9a80ab
Cr-Commit-Position: refs/heads/master@{#437899}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 21 (15 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by gab@chromium.org to run a CQ dry run
gab@chromium.org changed reviewers: + michaeln@chromium.org
@michaeln PTAL and CQ if it LGTY, thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gab@chromium.org changed reviewers: + cmumford@chromium.org - michaeln@chromium.org
Oops, read OWNERS wrong, @cmumford for review (please CQ if LGTY)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by cmumford@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481562099092300,
"parent_rev": "55756ef5ada42f2b21c9eb3c96340e6105eb09cc", "commit_rev":
"f2d0f2c9f1cc7a9bd32ce3e9e4f98b0d4358e20a"}
Message was sent while issue was closed.
Description was changed from ========== Fix TestBrowserThreadBundle destruction order in IndexedDBDatabaseOperationTest. IndexedDBDatabase requires BrowserThread::IO to be alive when it is destroyed or it leaks some of its DeleteOnIOThread scoped_refptr members. Not doing so results in LSAN failures in https://codereview.chromium.org/2464233002 per it tightening TestBrowserThread's shutdown semantics. BUG=653916 ========== to ========== Fix TestBrowserThreadBundle destruction order in IndexedDBDatabaseOperationTest. IndexedDBDatabase requires BrowserThread::IO to be alive when it is destroyed or it leaks some of its DeleteOnIOThread scoped_refptr members. Not doing so results in LSAN failures in https://codereview.chromium.org/2464233002 per it tightening TestBrowserThread's shutdown semantics. BUG=653916 Review-Url: https://codereview.chromium.org/2566693004 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix TestBrowserThreadBundle destruction order in IndexedDBDatabaseOperationTest. IndexedDBDatabase requires BrowserThread::IO to be alive when it is destroyed or it leaks some of its DeleteOnIOThread scoped_refptr members. Not doing so results in LSAN failures in https://codereview.chromium.org/2464233002 per it tightening TestBrowserThread's shutdown semantics. BUG=653916 Review-Url: https://codereview.chromium.org/2566693004 ========== to ========== Fix TestBrowserThreadBundle destruction order in IndexedDBDatabaseOperationTest. IndexedDBDatabase requires BrowserThread::IO to be alive when it is destroyed or it leaks some of its DeleteOnIOThread scoped_refptr members. Not doing so results in LSAN failures in https://codereview.chromium.org/2464233002 per it tightening TestBrowserThread's shutdown semantics. BUG=653916 Committed: https://crrev.com/9361390bd8a415b79cba242e70149bf6ca9a80ab Cr-Commit-Position: refs/heads/master@{#437899} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9361390bd8a415b79cba242e70149bf6ca9a80ab Cr-Commit-Position: refs/heads/master@{#437899} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
