Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: content/browser/indexed_db/indexed_db_database_unittest.cc

Issue 2566693004: Fix TestBrowserThreadBundle destruction order in IndexedDBDatabaseOperationTest. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/indexed_db_database_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_database_unittest.cc b/content/browser/indexed_db/indexed_db_database_unittest.cc
index 5d8550308cf03bd999ffe2fc5cd3fdecd1bcb8f9..953b7207c12da48b094ab108cf0c6e90511116bd 100644
--- a/content/browser/indexed_db/indexed_db_database_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_database_unittest.cc
@@ -377,6 +377,10 @@ class IndexedDBDatabaseOperationTest : public testing::Test {
void RunPostedTasks() { base::RunLoop().RunUntilIdle(); }
+private:
+ // Needs to outlive |db_|.
+ content::TestBrowserThreadBundle thread_bundle_;
+
protected:
scoped_refptr<IndexedDBFakeBackingStore> backing_store_;
scoped_refptr<IndexedDBDatabase> db_;
@@ -389,7 +393,6 @@ class IndexedDBDatabaseOperationTest : public testing::Test {
private:
scoped_refptr<MockIndexedDBFactory> factory_;
- content::TestBrowserThreadBundle thread_bundle_;
DISALLOW_COPY_AND_ASSIGN(IndexedDBDatabaseOperationTest);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698