Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2566493003: Remove CRWNetworkActivityIndicatorManager. (Closed)

Created:
4 years ago by michaeldo
Modified:
4 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CRWNetworkActivityIndicatorManager. This class was moved to renamed clone of ios/chrome/browser/ui/network_activity_indicator_manager.* since //ios/web should not be managing the system wide network activity indicator’s UI state. BUG=620887 Committed: https://crrev.com/d3a95787165f9403051af4bc62c3427223aa9732 Cr-Commit-Position: refs/heads/master@{#439148}

Patch Set 1 #

Patch Set 2 : Remove expectations from CRWPassKitDownloaderUnittest. #

Patch Set 3 : Add base build dep. #

Patch Set 4 : Remove duplicate file refs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -476 lines) Patch
M ios/chrome/browser/ui/BUILD.gn View 1 2 3 3 chunks +18 lines, -3 lines 0 comments Download
M ios/web/BUILD.gn View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
D ios/web/crw_network_activity_indicator_manager.h View 1 chunk +0 lines, -67 lines 0 comments Download
D ios/web/crw_network_activity_indicator_manager.mm View 1 chunk +0 lines, -116 lines 0 comments Download
D ios/web/crw_network_activity_indicator_manager_unittest.mm View 1 chunk +0 lines, -154 lines 0 comments Download
M ios/web/net/request_tracker_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/net/request_tracker_impl.mm View 6 chunks +0 lines, -46 lines 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader.mm View 8 chunks +0 lines, -36 lines 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader_unittest.mm View 1 7 chunks +0 lines, -16 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 3 7 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
michaeldo
4 years ago (2016-12-08 23:13:48 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years ago (2016-12-08 23:17:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566493003/20001
4 years ago (2016-12-16 16:11:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/124328) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-16 16:16:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566493003/40001
4 years ago (2016-12-16 16:23:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/124339) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-16 16:29:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566493003/60001
4 years ago (2016-12-16 17:05:09 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-16 18:15:59 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-16 18:19:48 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d3a95787165f9403051af4bc62c3427223aa9732
Cr-Commit-Position: refs/heads/master@{#439148}

Powered by Google App Engine
This is Rietveld 408576698