Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: ios/web/web_state/crw_pass_kit_downloader_unittest.mm

Issue 2566493003: Remove CRWNetworkActivityIndicatorManager. (Closed)
Patch Set: Remove duplicate file refs. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/crw_pass_kit_downloader.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/crw_pass_kit_downloader_unittest.mm
diff --git a/ios/web/web_state/crw_pass_kit_downloader_unittest.mm b/ios/web/web_state/crw_pass_kit_downloader_unittest.mm
index d832d327137aa7015630cb1d652a5f8f1fa9c580..9af61e4ee92084937ade8f2486303645552bf5ed 100644
--- a/ios/web/web_state/crw_pass_kit_downloader_unittest.mm
+++ b/ios/web/web_state/crw_pass_kit_downloader_unittest.mm
@@ -80,9 +80,6 @@ TEST_F(CRWPassKitDownloaderTest, TestDownloadPassKitSuccess) {
GURL test_url(kTestUrlString);
[downloader_ downloadPassKitFileWithURL:test_url];
- UIApplication* shared_app = [UIApplication sharedApplication];
- EXPECT_TRUE([shared_app isNetworkActivityIndicatorVisible]);
-
net::TestURLFetcher* fetcher = fetcher_factory_->GetFetcherByID(0);
ASSERT_TRUE(fetcher);
ASSERT_EQ(test_url, fetcher->GetOriginalURL());
@@ -90,7 +87,6 @@ TEST_F(CRWPassKitDownloaderTest, TestDownloadPassKitSuccess) {
fetcher->SetResponseString(kExpectedString);
fetcher->delegate()->OnURLFetchComplete(fetcher);
- EXPECT_FALSE([shared_app isNetworkActivityIndicatorVisible]);
EXPECT_TRUE(completion_handler_success_);
}
@@ -100,9 +96,6 @@ TEST_F(CRWPassKitDownloaderTest, TestDownloadPassKitBadErrorCodeFailure) {
GURL test_url(kTestUrlString);
[downloader_ downloadPassKitFileWithURL:test_url];
- UIApplication* shared_app = [UIApplication sharedApplication];
- EXPECT_TRUE([shared_app isNetworkActivityIndicatorVisible]);
-
net::TestURLFetcher* fetcher = fetcher_factory_->GetFetcherByID(0);
ASSERT_TRUE(fetcher);
ASSERT_EQ(test_url, fetcher->GetOriginalURL());
@@ -110,7 +103,6 @@ TEST_F(CRWPassKitDownloaderTest, TestDownloadPassKitBadErrorCodeFailure) {
fetcher->SetResponseString(kExpectedString);
fetcher->delegate()->OnURLFetchComplete(fetcher);
- EXPECT_FALSE([shared_app isNetworkActivityIndicatorVisible]);
EXPECT_FALSE(completion_handler_success_);
}
@@ -120,9 +112,6 @@ TEST_F(CRWPassKitDownloaderTest, TestDownloadPassKitStatusFailedFailure) {
GURL test_url(kTestUrlString);
[downloader_ downloadPassKitFileWithURL:test_url];
- UIApplication* shared_app = [UIApplication sharedApplication];
- EXPECT_TRUE([shared_app isNetworkActivityIndicatorVisible]);
-
net::TestURLFetcher* fetcher = fetcher_factory_->GetFetcherByID(0);
ASSERT_TRUE(fetcher);
ASSERT_EQ(test_url, fetcher->GetOriginalURL());
@@ -131,7 +120,6 @@ TEST_F(CRWPassKitDownloaderTest, TestDownloadPassKitStatusFailedFailure) {
fetcher->SetResponseString(kExpectedString);
fetcher->delegate()->OnURLFetchComplete(fetcher);
- EXPECT_FALSE([shared_app isNetworkActivityIndicatorVisible]);
EXPECT_FALSE(completion_handler_success_);
}
@@ -141,16 +129,12 @@ TEST_F(CRWPassKitDownloaderTest, TestDownloadPassKitNoResponseFailure) {
GURL test_url(kTestUrlString);
[downloader_ downloadPassKitFileWithURL:test_url];
- UIApplication* shared_app = [UIApplication sharedApplication];
- EXPECT_TRUE([shared_app isNetworkActivityIndicatorVisible]);
-
net::TestURLFetcher* fetcher = fetcher_factory_->GetFetcherByID(0);
ASSERT_TRUE(fetcher);
ASSERT_EQ(test_url, fetcher->GetOriginalURL());
SetUpFetcher(fetcher, URLRequestStatus(), 200, kPassKitMimeType);
fetcher->delegate()->OnURLFetchComplete(fetcher);
- EXPECT_FALSE([shared_app isNetworkActivityIndicatorVisible]);
EXPECT_FALSE(completion_handler_success_);
}
« no previous file with comments | « ios/web/web_state/crw_pass_kit_downloader.mm ('k') | ios/web/web_state/ui/crw_web_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698