Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2566463003:
DevTools: Do not attempt to create tooltips for cells with null value (e.g. creation nodes). (Closed)
|
Created:
4 years ago by kdzwinel Modified:
4 years ago Reviewers:
lushnikov CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDo not attempt to create tooltips for cells with null value (e.g. creation nodes).
Follow up to https://codereview.chromium.org/2551283002/
BUG=none
R=lushnikov
Committed: https://crrev.com/359b31b0fd9e0f8bad178963b999352b42f6582d
Cr-Commit-Position: refs/heads/master@{#438630}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address code review feedback. #Patch Set 3 : Revert previous fix. #Messages
Total messages: 22 (9 generated)
PTAL
thanks, lgtm https://codereview.chromium.org/2566463003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right): https://codereview.chromium.org/2566463003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:1484: } else if (data !== null) { nit: the "then" branch expects data to be string - we can state it explicitly here .. else if (typeof data === 'string') {
Sorry for a late response, I missed your comment!
The CQ bit was checked by lushnikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lushnikov@chromium.org Link to the patchset: https://codereview.chromium.org/2566463003/#ps20001 (title: "Address code review feedback.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
No worries; I hit the CQ checkbox for you
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by kdzwinel@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
PTAL https://codereview.chromium.org/2566463003/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right): https://codereview.chromium.org/2566463003/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:1484: } else if (data !== null) { On 2016/12/08 at 23:04:43, lushnikov wrote: > nit: the "then" branch expects data to be string - we can state it > explicitly here > > .. else if (typeof data === 'string') { Turns out it's not always the case: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/devtools/front... . This was causing tests to fail. I propose we go back to `data !== null`, WDYT?
ok, lgtm
The CQ bit was checked by kdzwinel@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481740863737800,
"parent_rev": "8dbb0c63516cca76b8cbe538e258ac09720223d2", "commit_rev":
"926398b19effa576852f741463b04a6488121415"}
Message was sent while issue was closed.
Description was changed from ========== Do not attempt to create tooltips for cells with null value (e.g. creation nodes). Follow up to https://codereview.chromium.org/2551283002/ BUG=none R=lushnikov ========== to ========== Do not attempt to create tooltips for cells with null value (e.g. creation nodes). Follow up to https://codereview.chromium.org/2551283002/ BUG=none R=lushnikov Review-Url: https://codereview.chromium.org/2566463003 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Do not attempt to create tooltips for cells with null value (e.g. creation nodes). Follow up to https://codereview.chromium.org/2551283002/ BUG=none R=lushnikov Review-Url: https://codereview.chromium.org/2566463003 ========== to ========== Do not attempt to create tooltips for cells with null value (e.g. creation nodes). Follow up to https://codereview.chromium.org/2551283002/ BUG=none R=lushnikov Committed: https://crrev.com/359b31b0fd9e0f8bad178963b999352b42f6582d Cr-Commit-Position: refs/heads/master@{#438630} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/359b31b0fd9e0f8bad178963b999352b42f6582d Cr-Commit-Position: refs/heads/master@{#438630} |
