Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js

Issue 2566463003: DevTools: Do not attempt to create tooltips for cells with null value (e.g. creation nodes). (Closed)
Patch Set: Revert previous fix. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
index 675221b5aae3a41004f02d9f479dcbcba3ca0d6d..a0d168801c08740abcff2514a2c5d4fc83580ff2 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js
@@ -1481,7 +1481,7 @@ UI.DataGridNode = class extends Common.Object {
var data = this.data[columnId];
if (data instanceof Node) {
cell.appendChild(data);
- } else {
+ } else if (data !== null) {
cell.textContent = data;
if (this.dataGrid._columns[columnId].longText)
cell.title = data;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698