[SPv2] Add createOpacityOnlyEffect test helper

[SPv2] Add createOpacityOnlyEffect test helper

This CL adds a test helper header platform/testing/PaintPropertyTestHelpers.h
for common operations that are used in SPv2-related tests.

createOpacityOnlyEffect is added to create effect nodes with only opacity,
other optional effects are assigned a no-op value, and local transform space
and clip are inherited from parent.

As a side change, rootPaintChunkProperties is also moved to the helper header
and renamed to defaultPaintChunkProperties.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/546898952c07ec24c20a83b68c68995357e2e203
Cr-Commit-Position: refs/heads/master@{#437994}

[trchen, 2016-12-09 23:59:28]

Description was changed from

==========
[SPv2] Add createOpacityOnlyEffect test helper

This CL adds a test helper header platform/testing/PaintPropertyTestHelpers.h
for common operations that are used in SPv2-related tests.

createOpacityOnlyEffect is added to create effect nodes with only opacity,
other optional effects are assigned a no-op value, and local transform space
and clip are inherited from parent.

As a side change, rootPaintChunkProperties is also moved to the helper header
and renamed to defaultPaintChunkProperties.
==========

to

==========
[SPv2] Add createOpacityOnlyEffect test helper

This CL adds a test helper header platform/testing/PaintPropertyTestHelpers.h
for common operations that are used in SPv2-related tests.

createOpacityOnlyEffect is added to create effect nodes with only opacity,
other optional effects are assigned a no-op value, and local transform space
and clip are inherited from parent.

As a side change, rootPaintChunkProperties is also moved to the helper header
and renamed to defaultPaintChunkProperties.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[trchen, 2016-12-10 00:01:54]

trchen@chromium.org changed reviewers:
+ pdr@chromium.org

[trchen, 2016-12-10 00:01:55]

Tired of rebasing every single test when new attribute getting added to property
nodes? Today we folks decided enough is enough! :D

[trchen, 2016-12-10 00:02:01]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 00:03:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 00:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 00:08:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[trchen, 2016-12-10 00:37:50]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 00:38:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 02:05:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 02:05:37]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pdr., 2016-12-12 18:47:09]

LGTM, power to the people!

https://codereview.chromium.org/2565903002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/testing/PaintPropertyTestHelpers.h
(right):

https://codereview.chromium.org/2565903002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/testing/PaintPropertyTestHelpers.h:14: static
inline PassRefPtr<EffectPaintPropertyNode>
createOpacityOnlyEffect(PassRefPtr<const EffectPaintPropertyNode> parent, float
opacity) {
Nit: please format to 80cols.

[trchen, 2016-12-12 21:36:10]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 21:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 00:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:37:13]

Dry run: This issue passed the CQ dry run.

[trchen, 2016-12-13 02:30:20]

The CQ bit was checked by trchen@chromium.org

[trchen, 2016-12-13 02:30:21]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2565903002/#ps40001
(title: "rebase && git cl format")

[commit-bot: I haz the power, 2016-12-13 02:31:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:37:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481596220974040,
"parent_rev": "bedecbc6b65901dca742e2054225aa8464f0ee08", "commit_rev":
"1fa7318db4aee10bd434e333bcd205d35fd344a3"}

[commit-bot: I haz the power, 2016-12-13 02:38:20]

Description was changed from

==========
[SPv2] Add createOpacityOnlyEffect test helper

This CL adds a test helper header platform/testing/PaintPropertyTestHelpers.h
for common operations that are used in SPv2-related tests.

createOpacityOnlyEffect is added to create effect nodes with only opacity,
other optional effects are assigned a no-op value, and local transform space
and clip are inherited from parent.

As a side change, rootPaintChunkProperties is also moved to the helper header
and renamed to defaultPaintChunkProperties.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPv2] Add createOpacityOnlyEffect test helper

This CL adds a test helper header platform/testing/PaintPropertyTestHelpers.h
for common operations that are used in SPv2-related tests.

createOpacityOnlyEffect is added to create effect nodes with only opacity,
other optional effects are assigned a no-op value, and local transform space
and clip are inherited from parent.

As a side change, rootPaintChunkProperties is also moved to the helper header
and renamed to defaultPaintChunkProperties.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2565903002
==========

[commit-bot: I haz the power, 2016-12-13 02:38:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-13 02:42:49]

Description was changed from

==========
[SPv2] Add createOpacityOnlyEffect test helper

This CL adds a test helper header platform/testing/PaintPropertyTestHelpers.h
for common operations that are used in SPv2-related tests.

createOpacityOnlyEffect is added to create effect nodes with only opacity,
other optional effects are assigned a no-op value, and local transform space
and clip are inherited from parent.

As a side change, rootPaintChunkProperties is also moved to the helper header
and renamed to defaultPaintChunkProperties.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2565903002
==========

to

==========
[SPv2] Add createOpacityOnlyEffect test helper

This CL adds a test helper header platform/testing/PaintPropertyTestHelpers.h
for common operations that are used in SPv2-related tests.

createOpacityOnlyEffect is added to create effect nodes with only opacity,
other optional effects are assigned a no-op value, and local transform space
and clip are inherited from parent.

As a side change, rootPaintChunkProperties is also moved to the helper header
and renamed to defaultPaintChunkProperties.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/546898952c07ec24c20a83b68c68995357e2e203
Cr-Commit-Position: refs/heads/master@{#437994}
==========

[commit-bot: I haz the power, 2016-12-13 02:42:50]

Patchset 3 (id:??) landed as
https://crrev.com/546898952c07ec24c20a83b68c68995357e2e203
Cr-Commit-Position: refs/heads/master@{#437994}