[SPv2] Add CSS mix-blend-mode support

[SPv2] Add CSS mix-blend-mode support

This CL adds blendMode field to EffectPaintPropertyNode, upgrades
PaintPropertyTreeBuilder to create effect nodes if CSS mix-blend-mode is
applied to an element and ensure propery isolation on the parent, and adds
corresponding conversion in PaintArtifactCompositor.

BUG=609937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bdc8576be81b557e582029633b76e509f15bd18f
Cr-Commit-Position: refs/heads/master@{#438775}

[trchen, 2016-12-09 22:49:28]

Description was changed from

==========
[SPv2] Add CSS mix-blend-mode support

This CL adds blendMode field to EffectPaintPropertyNode, upgrades
PaintPropertyTreeBuilder to create effect nodes if CSS mix-blend-mode is
applied to an element and ensure propery isolation on the parent, and adds
corresponding conversion in PaintArtifactCompositor.

BUG=609937
==========

to

==========
[SPv2] Add CSS mix-blend-mode support

This CL adds blendMode field to EffectPaintPropertyNode, upgrades
PaintPropertyTreeBuilder to create effect nodes if CSS mix-blend-mode is
applied to an element and ensure propery isolation on the parent, and adds
corresponding conversion in PaintArtifactCompositor.

BUG=609937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[trchen, 2016-12-10 00:09:06]

Patchset #1 (id:1) has been deleted

[trchen, 2016-12-10 00:10:49]

trchen@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[trchen, 2016-12-10 00:10:50]

Will rebaseline tests after trybots. ZZZzzZzzz...

[pdr., 2016-12-12 18:50:23]

Overall looks good. Can you remove any lines from TestExpectations with this
change?

[trchen, 2016-12-13 23:38:12]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 23:38:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[trchen, 2016-12-13 23:43:35]

Test expectation updated.
About 2/3 of css3/blending passed. Most of the failures are due to SVG blending
not implemented yet.

Only two tests are unexpected:
css3/blending/mix-blend-mode-has-ancestor-clipping-layer.html
css3/blending/mix-blend-mode-multiply.html

Probably some render surface bug in cc. Will diagnose later.

[pdr., 2016-12-14 01:04:20]

pdr@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[pdr., 2016-12-14 01:05:18]

LGTM, but please wait for WangXianzhu.

+reviewer wangxianzhu, can you double-check our approach to testing in
LayoutTests/FlagExpectations/enable-slimming-paint-2?

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:2163:
Bug(none)
css3/blending/background-blend-mode-overlapping-accelerated-elements.html [
Failure ]
Do you know why these fail? If so, can you label them with bugs? If not,
Bug(none) is fine for now.

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:384: // Yes,
including LayoutSVGRoot, because SVG layout objects don't create
Do we need to special-case isSVG here?

IOW, could we write this instead?
if (PaintLayer* layer = toLayoutBoxModelObject(object).layer()) {
  if (layer->hasNonIsolatedDescendantWithBlendMode())
    effectNodeNeeded = true;
} else if (object.hasNonIsolatedDescendantWithBlendMode()) {
  effectNodeIsNeeded = true;
}

[trchen, 2016-12-14 01:12:35]

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:384: // Yes,
including LayoutSVGRoot, because SVG layout objects don't create
On 2016/12/14 01:05:18, pdr. wrote:
> Do we need to special-case isSVG here?
> 
> IOW, could we write this instead?
> if (PaintLayer* layer = toLayoutBoxModelObject(object).layer()) {
>   if (layer->hasNonIsolatedDescendantWithBlendMode())
>     effectNodeNeeded = true;
> } else if (object.hasNonIsolatedDescendantWithBlendMode()) {
>   effectNodeIsNeeded = true;
> }

Type checking needs to come first. object may not be LayoutBoxModelObject. Also
object.hasNonIsolatedDescendantWithBlendMode() is only implemented for SVG.
Invoking it with anything other than SVG should die in panic.

I'm working on a SVG & effect node CL that should add some sense into this code.
:)

[Xianzhu, 2016-12-14 01:19:43]

lgtm

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.cpp
(right):

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/EffectPaintPropertyNode.cpp:25:

Please wait for https://codereview.chromium.org/2574713003/ landing, then rebase
on it and modify EffectPaintPropertyNode::toString() to dump the new field.

[commit-bot: I haz the power, 2016-12-14 01:40:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 01:40:23]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[trchen, 2016-12-14 01:49:55]

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
(right):

https://codereview.chromium.org/2564193002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:2163:
Bug(none)
css3/blending/background-blend-mode-overlapping-accelerated-elements.html [
Failure ]
Some of them yes, some of them no. I'd be happy to spend some time to categorize
failures, if you guys find it useful.

[trchen, 2016-12-14 02:25:27]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:26:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[trchen, 2016-12-14 02:27:53]

A stacking context (or isolating SVG element) may or may not omit effect nodes
depend on the existence of exotic blending children. We need to catch the case
at the children and invalidate their parent's property. A new CL is uploaded to
fix this. Please let me know if it still looks good. Thanks!

[commit-bot: I haz the power, 2016-12-14 03:17:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-14 03:17:12]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[trchen, 2016-12-15 03:33:50]

The CQ bit was checked by trchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 03:34:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 04:05:45]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[trchen, 2016-12-15 05:14:46]

The CQ bit was checked by trchen@chromium.org

[trchen, 2016-12-15 05:14:46]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org,
wangxianzhu@chromium.org
Link to the patchset: https://codereview.chromium.org/2564193002/#ps140001
(title: "fix msvc warning")

[commit-bot: I haz the power, 2016-12-15 05:15:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 07:30:17]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481778886159630,
"parent_rev": "b5013f2f578b6c3f764016cb717d8d58545dc546", "commit_rev":
"93a37b12df97efd487fb525c30c2026e06e24f4f"}

[commit-bot: I haz the power, 2016-12-15 07:30:47]

Description was changed from

==========
[SPv2] Add CSS mix-blend-mode support

This CL adds blendMode field to EffectPaintPropertyNode, upgrades
PaintPropertyTreeBuilder to create effect nodes if CSS mix-blend-mode is
applied to an element and ensure propery isolation on the parent, and adds
corresponding conversion in PaintArtifactCompositor.

BUG=609937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[SPv2] Add CSS mix-blend-mode support

This CL adds blendMode field to EffectPaintPropertyNode, upgrades
PaintPropertyTreeBuilder to create effect nodes if CSS mix-blend-mode is
applied to an element and ensure propery isolation on the parent, and adds
corresponding conversion in PaintArtifactCompositor.

BUG=609937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2564193002
==========

[commit-bot: I haz the power, 2016-12-15 07:30:48]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2016-12-15 07:32:51]

Description was changed from

==========
[SPv2] Add CSS mix-blend-mode support

This CL adds blendMode field to EffectPaintPropertyNode, upgrades
PaintPropertyTreeBuilder to create effect nodes if CSS mix-blend-mode is
applied to an element and ensure propery isolation on the parent, and adds
corresponding conversion in PaintArtifactCompositor.

BUG=609937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2564193002
==========

to

==========
[SPv2] Add CSS mix-blend-mode support

This CL adds blendMode field to EffectPaintPropertyNode, upgrades
PaintPropertyTreeBuilder to create effect nodes if CSS mix-blend-mode is
applied to an element and ensure propery isolation on the parent, and adds
corresponding conversion in PaintArtifactCompositor.

BUG=609937
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/bdc8576be81b557e582029633b76e509f15bd18f
Cr-Commit-Position: refs/heads/master@{#438775}
==========

[commit-bot: I haz the power, 2016-12-15 07:32:52]

Patchset 7 (id:??) landed as
https://crrev.com/bdc8576be81b557e582029633b76e509f15bd18f
Cr-Commit-Position: refs/heads/master@{#438775}