Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 2565403003: [HBD] Remove radio buttons from the Plugins Blocked Omnibox popup. (Closed)

Created:
4 years ago by tommycli
Modified:
4 years ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, laforge, ericde, groby-ooo-7-16
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[HBD] Remove radio buttons from the Plugins Blocked Omnibox popup. This CL does two things to the Plugins Block Omnibox popup: 1. Removes the radio buttons. They are misleading and irrelevant in the HBD world, and weren't actually that useful in the pre-HBD world either. 2. Hides the Run All Plugins link in the policy-managed BLOCK case or the HBD BLOCK case. 3. Hides the Manage... link in the policy-managed case. User cannot manage the setting anyways. BUG=655899 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2552343005 Cr-Commit-Position: refs/heads/master@{#437653} (cherry picked from commit cee4c12b4204f5ab1211903d0b5fd0da8b8b5c90) Review-Url: https://codereview.chromium.org/2565403003

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -85 lines) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.h View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 8 chunks +37 lines, -74 lines 0 comments Download
M chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
tommycli
bauerb: PTAL. Do you mind sanity checking this merge to M56? Original patch here: https://codereview.chromium.org/2552343005/ ...
4 years ago (2016-12-12 20:51:52 UTC) #10
Bernhard Bauer
lgtm
4 years ago (2016-12-13 11:35:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565403003/1
4 years ago (2016-12-13 16:08:29 UTC) #13
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years ago (2016-12-13 16:08:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565403003/1
4 years ago (2016-12-13 16:42:49 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-13 16:45:04 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698