Remove details panel.

Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=672767
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb
Cr-Commit-Position: refs/heads/master@{#437836}

[oka, 2016-12-12 06:45:07]

Description was changed from

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=664368
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
==========

to

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=664368
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-12-12 06:45:12]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 06:45:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-12-12 07:23:19]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-12-12 07:23:20]

PTAL.

[oka, 2016-12-12 07:27:22]

Description was changed from

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=664368
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=664368
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-12-12 07:28:27]

Description was changed from

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=664368
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=672767
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-12 07:29:15]

lgtm with a nit. Thanks!

https://codereview.chromium.org/2565333002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2565333002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:320: table,
grid, locationLine) {
Maybe it fits in 80 chars?

[oka, 2016-12-12 07:33:29]

https://codereview.chromium.org/2565333002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2565333002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:320: table,
grid, locationLine) {
On 2016/12/12 07:29:15, fukino wrote:
> Maybe it fits in 80 chars?

Done.

[oka, 2016-12-12 07:33:37]

The CQ bit was checked by oka@chromium.org

[oka, 2016-12-12 07:33:37]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2565333002/#ps20001
(title: "Fit a line into 80 chars.")

[commit-bot: I haz the power, 2016-12-12 07:33:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 08:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 08:19:11]

Failed to apply patch for
ui/file_manager/file_manager/foreground/js/compiled_resources.gyp:
While running git apply --index -p1;
  error: patch failed:
ui/file_manager/file_manager/foreground/js/compiled_resources.gyp:149
  error: ui/file_manager/file_manager/foreground/js/compiled_resources.gyp:
patch does not apply

Patch:       ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
Index: ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
diff --git a/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
b/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
index
850998fb66a3712179cae558c04a73ce10e21ff5..b12d8a5688d8c810cff58dc39fe21cb21e0e9433
100644
--- a/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
+++ b/ui/file_manager/file_manager/foreground/js/compiled_resources.gyp
@@ -131,7 +131,6 @@
           './ui/actions_submenu.js',
           './ui/banners.js',
           './ui/default_task_dialog.js',
-          './ui/details_container.js',
           './ui/dialog_footer.js',
           './ui/directory_tree.js',
           './ui/drag_selector.js',
@@ -149,14 +148,12 @@
           './ui/gear_menu.js',
           './ui/list_container.js',
           './ui/location_line.js',
-          './ui/multi_file_details.js',
           './ui/multi_profile_share_dialog.js',
           './ui/progress_center_panel.js',
           './ui/providers_menu.js',
           './ui/scrollbar.js',
           './ui/search_box.js',
           './ui/share_dialog.js',
-          './ui/single_file_details.js',
           './ui/suggest_apps_dialog.js',
           './main_window_component.js',
           './volume_manager_wrapper.js',

[oka, 2016-12-12 08:24:34]

The CQ bit was checked by oka@chromium.org

[oka, 2016-12-12 08:24:34]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2565333002/#ps40001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-12-12 08:24:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 09:20:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481531074131360,
"parent_rev": "ecee37c7525c23e085694f70589f170cb15e1e9f", "commit_rev":
"e1cd1075dc887838798512bc95d9fe1925a5a5d5"}

[commit-bot: I haz the power, 2016-12-12 09:20:44]

Description was changed from

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=672767
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=672767
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2565333002
==========

[commit-bot: I haz the power, 2016-12-12 09:20:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-12 15:11:09]

Description was changed from

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=672767
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2565333002
==========

to

==========
Remove details panel.

Details panel was being developed under a flag, but has been replaced
with Quick View and is no longer needed.

BUG=672767
TEST=Manually tested that FileManager successfully launches using
Linux. git cl try.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb
Cr-Commit-Position: refs/heads/master@{#437836}
==========

[commit-bot: I haz the power, 2016-12-12 15:11:10]

Patchset 3 (id:??) landed as
https://crrev.com/86cc6307099df2aa19fac30eae8bbae90bbb57cb
Cr-Commit-Position: refs/heads/master@{#437836}