Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js

Issue 2565333002: Remove details panel. (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
diff --git a/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js b/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
index a6e91eedf93b5bb66a482b2570462be51deac96f..ce7f1cb8b25a7bbb7ab51cb13a5f31f72767701e 100644
--- a/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
+++ b/ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js
@@ -162,23 +162,6 @@ function FileManagerUI(providersModel, element, launchParam) {
'#sort-button', cr.ui.MenuButton);
/**
- * The button to open the details panel.
- * @type {!Element}
- * @const
- */
- this.detailsButton = queryRequiredElement(
- '#details-button', this.element);
-
- /**
- * Ripple effect of details button.
- * @private {!FilesToggleRipple}
- * @const
- */
- this.detailsButtonToggleRipple_ =
- /** @type {!FilesToggleRipple} */ (queryRequiredElement(
- 'files-toggle-ripple', this.detailsButton));
-
- /**
* Ripple effect of sort button.
* @private {!FilesToggleRipple}
* @const
@@ -231,12 +214,6 @@ function FileManagerUI(providersModel, element, launchParam) {
this.listContainer = null;
/**
- * Details container.
- * @type {DetailsContainer}
- */
- this.detailsContainer = null;
-
- /**
* @type {!HTMLElement}
*/
this.formatPanelError =
@@ -337,12 +314,9 @@ function FileManagerUI(providersModel, element, launchParam) {
*
* @param {!FileTable} table
* @param {!FileGrid} grid
- * @param {!SingleFileDetailsPanel} singlePanel
- * @param {!MultiFileDetailsPanel} multiPanel
* @param {!LocationLine} locationLine
*/
-FileManagerUI.prototype.initAdditionalUI = function(
- table, grid, singlePanel, multiPanel, locationLine) {
+FileManagerUI.prototype.initAdditionalUI = function(table, grid, locationLine) {
// List container.
this.listContainer = new ListContainer(
queryRequiredElement('#list-container', this.element), table, grid);
@@ -351,25 +325,6 @@ FileManagerUI.prototype.initAdditionalUI = function(
this.decorateSplitter_(
queryRequiredElement('#navigation-list-splitter', this.element));
- // Details container.
- var listDetailsSplitter =
- queryRequiredElement('#list-details-splitter', this.element);
- this.decorateSplitter_(listDetailsSplitter, true);
- this.detailsContainer = new DetailsContainer(
- queryRequiredElement('#details-container', this.element),
- singlePanel,
- multiPanel,
- listDetailsSplitter,
- this.detailsButton,
- this.detailsButtonToggleRipple_);
-
- chrome.commandLinePrivate.hasSwitch('enable-files-details-panel',
- function(enabled) {
- if (enabled) {
- this.detailsButton.style.display = 'block';
- }
- }.bind(this));
-
// Location line.
this.locationLine = locationLine;
@@ -490,17 +445,6 @@ FileManagerUI.prototype.setCurrentListType = function(listType) {
};
/**
- * Sets the details panel visibility
- * @param {boolean} visibility True if the details panel is visible.
- */
-FileManagerUI.prototype.setDetailsVisibility = function(visibility) {
- if (this.detailsContainer) {
- this.detailsContainer.setVisibility(visibility);
- this.relayout();
- }
-};
-
-/**
* Overrides default handling for clicks on hyperlinks.
* In a packaged apps links with targer='_blank' open in a new tab by
* default, other links do not open at all.

Powered by Google App Engine
This is Rietveld 408576698