third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp - Issue 2565323003: Move gif image decoder to SkCodec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

Issue 2565323003: Move gif image decoder to SkCodec (Closed)

Patch Set: Fixing the alpha, not changing frame between init and decode. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

index ea4acb278a050386e79e3c5a1a48017b193c7694..22755c40331b479aaea5b48852bae3b9d5aa6bf8 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

@@ -79,7 +79,6 @@ TEST(GIFImageDecoderTest, decodeTwoFrames) {

RefPtr<SharedBuffer> data = readFile(layoutTestResourcesDir, "animated.gif");

ASSERT_TRUE(data.get());

decoder->setData(data.get(), true);

- EXPECT_EQ(cAnimationLoopOnce, decoder->repetitionCount());

cblume 2017/01/09 04:11:22 This test *used* to assert that we hadn't yet seen

ImageFrame* frame = decoder->frameBufferAtIndex(0);

uint32_t generationID0 = frame->bitmap().getGenerationID();