Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2565203002: Add a requestFullscreen variant with a default (prefixed) type (Closed)

Created:
4 years ago by foolip
Modified:
4 years ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, feature-vr-reviews_chromium.org, fs, gasubic, haraken, kinuko+watch, mlamouri+watch-blink_chromium.org, rwlbuis, sof, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a requestFullscreen variant with a default (prefixed) type This is refactoring only, with the exception of VRDisplay.cpp, which changes from unprefixed to prefixed. As per the TODO, the idea is to make the default type depend on RuntimeEnabledFeatures::fullscreenUnprefixedEnabled(). Also make RequestType an enum class while in the area. BUG=402376 Committed: https://crrev.com/e0f53cb2304b26339df19a65b40137651a3346b1 Cr-Commit-Position: refs/heads/master@{#437856}

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
foolip
PTAL and CQ
4 years ago (2016-12-11 19:48:50 UTC) #4
mlamouri (slow - plz ping)
Leave a TODO(foolip), get things fix the next week <3 lgtm
4 years ago (2016-12-12 10:40:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565203002/1
4 years ago (2016-12-12 12:42:52 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 12:47:23 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0f53cb2304b26339df19a65b40137651a3346b1
Cr-Commit-Position: refs/heads/master@{#437856}

Powered by Google App Engine
This is Rietveld 408576698