Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2565203002: Add a requestFullscreen variant with a default (prefixed) type (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index c0258ffea3528dc98818208be8287cea9124c381..b294ca1d60e980d490c88ab563e0888c6ece2e20 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -1723,7 +1723,7 @@ TEST_P(WebViewTest, FullscreenResetScrollAndScaleFullscreenStyles) {
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
Element* element = document->getElementById("fullscreenElement");
UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
- Fullscreen::requestFullscreen(*element, Fullscreen::PrefixedRequest);
+ Fullscreen::requestFullscreen(*element);
webViewImpl->didEnterFullscreen();
webViewImpl->updateAllLifecyclePhases();
@@ -1764,7 +1764,7 @@ TEST_P(WebViewTest, FullscreenResetScrollAndScaleExitAndReenter) {
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
Element* element = document->getElementById("fullscreenElement");
UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
- Fullscreen::requestFullscreen(*element, Fullscreen::PrefixedRequest);
+ Fullscreen::requestFullscreen(*element);
webViewImpl->didEnterFullscreen();
webViewImpl->updateAllLifecyclePhases();
@@ -1779,7 +1779,7 @@ TEST_P(WebViewTest, FullscreenResetScrollAndScaleExitAndReenter) {
// shouldn't try to restore the scroll and scale values when we layout to
// enter fullscreen.
webViewImpl->didExitFullscreen();
- Fullscreen::requestFullscreen(*element, Fullscreen::PrefixedRequest);
+ Fullscreen::requestFullscreen(*element);
webViewImpl->didEnterFullscreen();
webViewImpl->updateAllLifecyclePhases();
@@ -1821,7 +1821,7 @@ TEST_P(WebViewTest, EnterFullscreenResetScrollAndScaleState) {
Document* document = webViewImpl->mainFrameImpl()->frame()->document();
Element* element = document->body();
UserGestureIndicator gesture(DocumentUserGestureToken::create(document));
- Fullscreen::requestFullscreen(*element, Fullscreen::PrefixedRequest);
+ Fullscreen::requestFullscreen(*element);
webViewImpl->didEnterFullscreen();
// Page scale factor must be 1.0 during fullscreen for elements to be sized
@@ -1830,7 +1830,7 @@ TEST_P(WebViewTest, EnterFullscreenResetScrollAndScaleState) {
// Make sure fullscreen nesting doesn't disrupt scroll/scale saving.
Element* otherElement = document->getElementById("content");
- Fullscreen::requestFullscreen(*otherElement, Fullscreen::PrefixedRequest);
+ Fullscreen::requestFullscreen(*otherElement);
// Confirm that exiting fullscreen restores the parameters.
webViewImpl->didExitFullscreen();
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698