Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7392)

Unified Diff: chrome/browser/password_manager/password_store_x.h

Issue 2565173002: Remove ScopedVector from PasswordStoreX (Closed)
Patch Set: back_inserter, no =nullptr, drop autofill:: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_x.h
diff --git a/chrome/browser/password_manager/password_store_x.h b/chrome/browser/password_manager/password_store_x.h
index 82a811bf84f0dfbcc622a5ff5572789d5229ddae..ec314d12996a85cf223769e49323a1ec5e8ac80d 100644
--- a/chrome/browser/password_manager/password_store_x.h
+++ b/chrome/browser/password_manager/password_store_x.h
@@ -11,7 +11,6 @@
#include <vector>
#include "base/macros.h"
-#include "base/memory/scoped_vector.h"
#include "base/time/time.h"
#include "components/password_manager/core/browser/password_store_default.h"
@@ -73,13 +72,16 @@ class PasswordStoreX : public password_manager::PasswordStoreDefault {
// matching |form|, all stored non-blacklisted credentials, and all stored
// blacklisted credentials, respectively. On success, they return true.
virtual bool GetLogins(const FormDigest& form,
- ScopedVector<autofill::PasswordForm>* forms)
- WARN_UNUSED_RESULT = 0;
+ std::vector<std::unique_ptr<autofill::PasswordForm>>*
+ forms) WARN_UNUSED_RESULT = 0;
virtual bool GetAutofillableLogins(
- ScopedVector<autofill::PasswordForm>* forms) WARN_UNUSED_RESULT = 0;
- virtual bool GetBlacklistLogins(ScopedVector<autofill::PasswordForm>* forms)
+ std::vector<std::unique_ptr<autofill::PasswordForm>>* forms)
+ WARN_UNUSED_RESULT = 0;
+ virtual bool GetBlacklistLogins(
+ std::vector<std::unique_ptr<autofill::PasswordForm>>* forms)
WARN_UNUSED_RESULT = 0;
- virtual bool GetAllLogins(ScopedVector<autofill::PasswordForm>* forms)
+ virtual bool GetAllLogins(
+ std::vector<std::unique_ptr<autofill::PasswordForm>>* forms)
WARN_UNUSED_RESULT = 0;
};

Powered by Google App Engine
This is Rietveld 408576698