Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/android/physical_web/physical_web_data_source_android.cc

Issue 2565023002: Use GURLs in Physical Web data source (Closed)
Patch Set: Register missing dependencies Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/physical_web/physical_web_data_source_android.cc
diff --git a/chrome/browser/android/physical_web/physical_web_data_source_android.cc b/chrome/browser/android/physical_web/physical_web_data_source_android.cc
index 362cd2e04e4b2d9cca409017c8a48b2b7d8b7c67..9e86f43a6cfe9c3d40ca2e22e7bec89e3b7159aa 100644
--- a/chrome/browser/android/physical_web/physical_web_data_source_android.cc
+++ b/chrome/browser/android/physical_web/physical_web_data_source_android.cc
@@ -104,16 +104,14 @@ void PhysicalWebDataSourceAndroid::OnFound(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& j_url) {
- std::string url = ConvertJavaStringToUTF8(env, j_url);
- NotifyOnFound(url);
+ NotifyOnFound(GURL(ConvertJavaStringToUTF8(env, j_url)));
}
void PhysicalWebDataSourceAndroid::OnLost(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& j_url) {
- std::string url = ConvertJavaStringToUTF8(env, j_url);
- NotifyOnLost(url);
+ NotifyOnLost(GURL(ConvertJavaStringToUTF8(env, j_url)));
}
void PhysicalWebDataSourceAndroid::OnDistanceChanged(
@@ -121,8 +119,8 @@ void PhysicalWebDataSourceAndroid::OnDistanceChanged(
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jstring>& j_url,
jdouble distance_estimate) {
- std::string url = ConvertJavaStringToUTF8(env, j_url);
- NotifyOnDistanceChanged(url, distance_estimate);
+ NotifyOnDistanceChanged(GURL(ConvertJavaStringToUTF8(env, j_url)),
+ distance_estimate);
}
// static

Powered by Google App Engine
This is Rietveld 408576698