Split browser-specific and generic code in components/task_scheduler_util/.

Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

TBR=blundell@chromium.org
BUG=664996
Committed: https://crrev.com/4b4ca6521434859be5c614f961ec72b9e19826cc
Cr-Commit-Position: refs/heads/master@{#439481}

[fdoray, 2016-12-09 22:40:49]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2016-12-09 22:40:49]

You may take a look, but I haven't done a thorough review myself. I will
self-review Monday morning :)

[fdoray, 2016-12-12 13:12:06]

PTAL

[gab, 2016-12-12 17:07:21]

lgtm overall w/ comments, less LOCs to do the same thing with what looks to me
like the same readability = yay :).

I'll let Rob do the in-depth review.

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:18: struct
SchedulerVariableWorkerPoolParams {
s/Variable/Customizable/ ?

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:75:
base::ThreadPriority priority_hint)
name_in, priority_hint_in

(I prefer that for structs as it avoids name resolution confusion for the
reader, e.g. say the variable was used in the body, which one prevails?)

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:85: const auto* const
worker_pool_name = constant_worker_pool_params.name;
s/auto/char/

same length so auto merely hinders readability

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.h:17: struct
SchedulerConstantWorkerPoolParams {
Comment (mention it's an immutable data struct) and maybe consider
s/Constant/Immutable/ ?

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.h:21: const char* name;
const char* const

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.h:22: base::ThreadPriority
priority_hint;
const

[fdoray, 2016-12-12 18:30:06]

robliao@: PTAL

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.cc (right):

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:18: struct
SchedulerVariableWorkerPoolParams {
On 2016/12/12 17:07:21, gab wrote:
> s/Variable/Customizable/ ?

Done.

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:75:
base::ThreadPriority priority_hint)
On 2016/12/12 17:07:21, gab wrote:
> name_in, priority_hint_in
> 
> (I prefer that for structs as it avoids name resolution confusion for the
> reader, e.g. say the variable was used in the body, which one prevails?)

Done.

https://codereview.chromium.org/2565013002/diff/100001/components/task_schedu...
components/task_scheduler_util/common/variations_util.cc:85: const auto* const
worker_pool_name = constant_worker_pool_params.name;
On 2016/12/12 17:07:21, gab wrote:
> s/auto/char/
> 
> same length so auto merely hinders readability

Done.

[fdoray, 2016-12-14 17:31:11]

robliao@: PTAnL

You can review even if I didn't change the upstream patch yet.

[robliao, 2016-12-14 18:54:39]

On 2016/12/14 17:31:11, fdoray wrote:
> robliao@: PTAnL
> 
> You can review even if I didn't change the upstream patch yet.

Thanks for the reminder. I started and then stopped and had to get on a plane
:-).

[robliao, 2016-12-14 20:46:17]

On 2016/12/14 18:54:39, robliao wrote:
> On 2016/12/14 17:31:11, fdoray wrote:
> > robliao@: PTAnL
> > 
> > You can review even if I didn't change the upstream patch yet.
> 
> Thanks for the reminder. I started and then stopped and had to get on a plane
> :-).

This change will cause a build break in iOS land. Can this change be staged
similar to how I initially performed the refactor?
(e.g. old paths work, new paths are created and we can migrate piecemeal
updating and removing at the same time without breaking the build).

[robliao, 2016-12-14 20:46:48]

High level comments.

https://codereview.chromium.org/2565013002/diff/180001/chrome/browser/chrome_...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2565013002/diff/180001/chrome/browser/chrome_...
chrome/browser/chrome_content_browser_client.cc:3339: if
(variations::GetVariationParams("BrowserScheduler", &variation_params)) {
One of the benefits of keeping this lookup handling in components is that all
platforms update at the same time (so we don't need to change iOS and Desktop
all the time). 

Can we still do that here?

https://codereview.chromium.org/2565013002/diff/180001/components/task_schedu...
File components/task_scheduler_util/common/BUILD.gn (right):

https://codereview.chromium.org/2565013002/diff/180001/components/task_schedu...
components/task_scheduler_util/common/BUILD.gn:5: static_library("common") {
Is the variations->common directory change necessary? The only thing in these
files are relevant to variations.

[fdoray, 2016-12-14 21:03:12]

https://codereview.chromium.org/2565013002/diff/180001/chrome/browser/chrome_...
File chrome/browser/chrome_content_browser_client.cc (right):

https://codereview.chromium.org/2565013002/diff/180001/chrome/browser/chrome_...
chrome/browser/chrome_content_browser_client.cc:3339: if
(variations::GetVariationParams("BrowserScheduler", &variation_params)) {
On 2016/12/14 20:46:48, robliao wrote:
> One of the benefits of keeping this lookup handling in components is that all
> platforms update at the same time (so we don't need to change iOS and Desktop
> all the time). 
> 
> Can we still do that here?

GetBrowserWorkerPoolParams(std::map<...>) can receive a map from
variations::GetVariationParams or a default map
https://codereview.chromium.org/2565013002/diff/180001/ios/chrome/browser/ios...

If you want, I could have:

// Generates a vector of SchedulerWorkerPoolParams using
// |variation_params|.
GetBrowserWorkerPoolParams(std::map<...> variation_params)

// Calls GetBrowserWorkerPoolParams() with
// a map obtained from variations::GetVariationParams.
GetBrowserWorkerPoolParamsFromVariations()

https://codereview.chromium.org/2565013002/diff/180001/components/task_schedu...
File components/task_scheduler_util/common/BUILD.gn (right):

https://codereview.chromium.org/2565013002/diff/180001/components/task_schedu...
components/task_scheduler_util/common/BUILD.gn:5: static_library("common") {
On 2016/12/14 20:46:48, robliao wrote:
> Is the variations->common directory change necessary? The only thing in these
> files are relevant to variations.

Makes it clear that this will be used in browser and renderer processes
https://codereview.chromium.org/2568793003/. This is a "common" pattern in
components/
https://cs.chromium.org/search/?q=file:components/.*/common&sq=package:chromi...
Also, the whole component is related to variations, so it might not be clear
what goes in a variations/ subdirectory.

If you have strong feelings, I could keep variations/.

[robliao, 2016-12-14 21:41:58]

On 2016/12/14 21:03:12, fdoray wrote:
>
https://codereview.chromium.org/2565013002/diff/180001/chrome/browser/chrome_...
> File chrome/browser/chrome_content_browser_client.cc (right):
> 
>
https://codereview.chromium.org/2565013002/diff/180001/chrome/browser/chrome_...
> chrome/browser/chrome_content_browser_client.cc:3339: if
> (variations::GetVariationParams("BrowserScheduler", &variation_params)) {
> On 2016/12/14 20:46:48, robliao wrote:
> > One of the benefits of keeping this lookup handling in components is that
all
> > platforms update at the same time (so we don't need to change iOS and
Desktop
> > all the time). 
> > 
> > Can we still do that here?
> 
> GetBrowserWorkerPoolParams(std::map<...>) can receive a map from
> variations::GetVariationParams or a default map
>
https://codereview.chromium.org/2565013002/diff/180001/ios/chrome/browser/ios...
> 
> If you want, I could have:
> 
> // Generates a vector of SchedulerWorkerPoolParams using
> // |variation_params|.
> GetBrowserWorkerPoolParams(std::map<...> variation_params)
> 
> // Calls GetBrowserWorkerPoolParams() with
> // a map obtained from variations::GetVariationParams.
> GetBrowserWorkerPoolParamsFromVariations()
> 
>
https://codereview.chromium.org/2565013002/diff/180001/components/task_schedu...
> File components/task_scheduler_util/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2565013002/diff/180001/components/task_schedu...
> components/task_scheduler_util/common/BUILD.gn:5: static_library("common") {
> On 2016/12/14 20:46:48, robliao wrote:
> > Is the variations->common directory change necessary? The only thing in
these
> > files are relevant to variations.
> 
> Makes it clear that this will be used in browser and renderer processes
> https://codereview.chromium.org/2568793003/. This is a "common" pattern in
> components/
>
https://cs.chromium.org/search/?q=file:components/.*/common&sq=package:chromi...
> Also, the whole component is related to variations, so it might not be clear
> what goes in a variations/ subdirectory.
> 
> If you have strong feelings, I could keep variations/.

Sorry, my earlier message broke off from the main feedback. What about the
staging to make iOS migration easier?

[fdoray, 2016-12-15 20:35:54]

Description was changed from

==========
Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

BUG=664996
==========

to

==========
Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing 
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

BUG=664996
==========

[fdoray, 2016-12-15 20:36:12]

robliao@: PTAnL

[fdoray, 2016-12-15 20:36:17]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 20:37:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robliao, 2016-12-15 20:41:10]

https://codereview.chromium.org/2565013002/diff/200001/components/task_schedu...
File components/task_scheduler_util/initialization/BUILD.gn (left):

https://codereview.chromium.org/2565013002/diff/200001/components/task_schedu...
components/task_scheduler_util/initialization/BUILD.gn:5:
static_library("initialization") {
This is still showing as deleted. Patch upload issue?

[commit-bot: I haz the power, 2016-12-15 20:42:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 20:42:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[robliao, 2016-12-15 20:45:41]

https://codereview.chromium.org/2565013002/diff/200001/components/task_schedu...
File components/task_scheduler_util/initialization/BUILD.gn (left):

https://codereview.chromium.org/2565013002/diff/200001/components/task_schedu...
components/task_scheduler_util/initialization/BUILD.gn:5:
static_library("initialization") {
On 2016/12/15 20:41:09, robliao wrote:
> This is still showing as deleted. Patch upload issue?

Looks like it might be a rietveld issue. The raw patch seems to have reasonable
data.

[fdoray, 2016-12-15 20:47:26]

https://codereview.chromium.org/2565013002/diff/200001/components/task_schedu...
File components/task_scheduler_util/initialization/BUILD.gn (left):

https://codereview.chromium.org/2565013002/diff/200001/components/task_schedu...
components/task_scheduler_util/initialization/BUILD.gn:5:
static_library("initialization") {
On 2016/12/15 20:45:41, robliao wrote:
> On 2016/12/15 20:41:09, robliao wrote:
> > This is still showing as deleted. Patch upload issue?
> 
> Looks like it might be a rietveld issue. The raw patch seems to have
reasonable
> data.

Yes, it's a rietveld issue. I am no longer deleting this file.

[robliao, 2016-12-15 21:26:46]

Looking good. Thanks for the transitional change.

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
File components/task_scheduler_util/browser/initialization.h (right):

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
components/task_scheduler_util/browser/initialization.h:30:
GetDefaultBrowserWorkerPoolParams();
This is no longer required with the committed iOS init changes.

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
components/task_scheduler_util/common/variations_util.h:21: const char* const
name;
Doesn't the const violate std::vector's requirement that items be MoveAssignable
or MoveInsertable?

I'd be fine having accessors here or non-const.

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
File components/task_scheduler_util/initialization/browser_util.cc (left):

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
components/task_scheduler_util/initialization/browser_util.cc:87: #if
defined(OS_IOS)
This can be removed. Looks like I missed this in my iOS migration change.

[fdoray, 2016-12-15 21:46:29]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 21:47:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-15 21:48:49]

PTAnL

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
File components/task_scheduler_util/browser/initialization.h (right):

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
components/task_scheduler_util/browser/initialization.h:30:
GetDefaultBrowserWorkerPoolParams();
On 2016/12/15 21:26:46, robliao wrote:
> This is no longer required with the committed iOS init changes.

Done.

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
components/task_scheduler_util/common/variations_util.h:21: const char* const
name;
On 2016/12/15 21:26:46, robliao wrote:
> Doesn't the const violate std::vector's requirement that items be
MoveAssignable
> or MoveInsertable?
> 
> I'd be fine having accessors here or non-const.

That's what I thought. I was surprised to see that it still compiled on Windows
after gab@ asked me to add const. I'll see what the bots say on other platforms.

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
File components/task_scheduler_util/initialization/browser_util.cc (left):

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
components/task_scheduler_util/initialization/browser_util.cc:87: #if
defined(OS_IOS)
On 2016/12/15 21:26:46, robliao wrote:
> This can be removed. Looks like I missed this in my iOS migration change.

Done.

[commit-bot: I haz the power, 2016-12-15 21:53:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 21:53:11]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[robliao, 2016-12-15 22:07:09]

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
components/task_scheduler_util/common/variations_util.h:21: const char* const
name;
On 2016/12/15 21:48:49, fdoray wrote:
> On 2016/12/15 21:26:46, robliao wrote:
> > Doesn't the const violate std::vector's requirement that items be
> MoveAssignable
> > or MoveInsertable?
> > 
> > I'd be fine having accessors here or non-const.
> 
> That's what I thought. I was surprised to see that it still compiled on
Windows
> after gab@ asked me to add const. I'll see what the bots say on other
platforms.

While it may not fail now, at the point anyone tries to do anything in the
vector, bad things may happen.
The standard for C++11 is...
   The requirements that are imposed on the elements depend on the actual
operations performed on the container. 

So I guess so long as we're the only ones who need this, this will be fine.

https://codereview.chromium.org/2565013002/diff/240001/components/task_schedu...
File components/task_scheduler_util/initialization/browser_util.h (right):

https://codereview.chromium.org/2565013002/diff/240001/components/task_schedu...
components/task_scheduler_util/initialization/browser_util.h:22: size_t
BrowserWorkerPoolIndexForTraits(const base::TaskTraits& traits);
Quick iOS Build: This needs stddef.h

https://codereview.chromium.org/2565013002/diff/240001/components/task_schedu...
File components/task_scheduler_util/variations/browser_variations_util.h
(right):

https://codereview.chromium.org/2565013002/diff/240001/components/task_schedu...
components/task_scheduler_util/variations/browser_variations_util.h:15: class
SchedulerWorkerPoolParams;
I forgot about this until I built it.

It's basically impossible to use
GetBrowserSchedulerWorkerPoolParamsFromVariations without this include file
(even if you're just passing it on), so no need to forward declare it.

[fdoray, 2016-12-16 13:05:31]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 13:05:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-12-16 13:06:44]

robliao@: PTAnL

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
File components/task_scheduler_util/common/variations_util.h (right):

https://codereview.chromium.org/2565013002/diff/220001/components/task_schedu...
components/task_scheduler_util/common/variations_util.h:21: const char* const
name;
On 2016/12/15 22:07:08, robliao wrote:
> On 2016/12/15 21:48:49, fdoray wrote:
> > On 2016/12/15 21:26:46, robliao wrote:
> > > Doesn't the const violate std::vector's requirement that items be
> > MoveAssignable
> > > or MoveInsertable?
> > > 
> > > I'd be fine having accessors here or non-const.
> > 
> > That's what I thought. I was surprised to see that it still compiled on
> Windows
> > after gab@ asked me to add const. I'll see what the bots say on other
> platforms.
> 
> While it may not fail now, at the point anyone tries to do anything in the
> vector, bad things may happen.
> The standard for C++11 is...
>    The requirements that are imposed on the elements depend on the actual
> operations performed on the container. 
> 
> So I guess so long as we're the only ones who need this, this will be fine.
> 

Acknowledged.

https://codereview.chromium.org/2565013002/diff/240001/components/task_schedu...
File components/task_scheduler_util/initialization/browser_util.h (right):

https://codereview.chromium.org/2565013002/diff/240001/components/task_schedu...
components/task_scheduler_util/initialization/browser_util.h:22: size_t
BrowserWorkerPoolIndexForTraits(const base::TaskTraits& traits);
On 2016/12/15 22:07:09, robliao wrote:
> Quick iOS Build: This needs stddef.h

Done.

https://codereview.chromium.org/2565013002/diff/240001/components/task_schedu...
File components/task_scheduler_util/variations/browser_variations_util.h
(right):

https://codereview.chromium.org/2565013002/diff/240001/components/task_schedu...
components/task_scheduler_util/variations/browser_variations_util.h:15: class
SchedulerWorkerPoolParams;
On 2016/12/15 22:07:09, robliao wrote:
> I forgot about this until I built it.
> 
> It's basically impossible to use
> GetBrowserSchedulerWorkerPoolParamsFromVariations without this include file
> (even if you're just passing it on), so no need to forward declare it.

Done.

[commit-bot: I haz the power, 2016-12-16 13:07:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 13:07:19]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[robliao, 2016-12-16 19:23:58]

lgtm + builds on iOS on my checkout. Thanks!

Looks like there may be patch conflicts at Tip of Trunk though.

[fdoray, 2016-12-19 13:12:56]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-12-19 13:12:56]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
robliao@chromium.org
Link to the patchset: https://codereview.chromium.org/2565013002/#ps280001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-19 13:13:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 13:19:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 13:19:32]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fdoray, 2016-12-19 13:55:04]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-12-19 13:55:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
robliao@chromium.org, gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2565013002/#ps300001
(title: "fix build error")

[commit-bot: I haz the power, 2016-12-19 13:55:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 14:02:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 14:02:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fdoray, 2016-12-19 14:14:04]

Description was changed from

==========
Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing 
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

BUG=664996
==========

to

==========
Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing 
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

TBR=blundell@chromium.org
BUG=664996
==========

[fdoray, 2016-12-19 14:14:24]

fdoray@chromium.org changed reviewers:
+ blundell@chromium.org

[fdoray, 2016-12-19 14:14:24]

TBR=blundell@chromium.org for components/BUILD.gn

[fdoray, 2016-12-19 14:14:31]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-12-19 14:14:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 14:32:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 14:32:48]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fdoray, 2016-12-19 14:47:59]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-12-19 14:48:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
robliao@chromium.org, gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2565013002/#ps320001
(title: "fix linux build error")

[commit-bot: I haz the power, 2016-12-19 14:48:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 15:58:43]

CQ is committing da patch.

Bot data: {"patchset_id": 320001, "attempt_start_ts": 1482158879924190,
"parent_rev": "0a46385d7ce30c80f77400aa557a8798db3af98f", "commit_rev":
"ff20f3856f16e5c9fcd3b6c9d198cbe9b5c198a2"}

[commit-bot: I haz the power, 2016-12-19 15:59:15]

Description was changed from

==========
Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing 
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

TBR=blundell@chromium.org
BUG=664996
==========

to

==========
Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing 
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

TBR=blundell@chromium.org
BUG=664996

Review-Url: https://codereview.chromium.org/2565013002
==========

[commit-bot: I haz the power, 2016-12-19 15:59:17]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2016-12-19 16:00:46]

Description was changed from

==========
Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing 
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

TBR=blundell@chromium.org
BUG=664996

Review-Url: https://codereview.chromium.org/2565013002
==========

to

==========
Split browser-specific and generic code in components/task_scheduler_util/.

This will allow code to be reused to initialize TaskScheduler based on
variation params in renderers.

To avoid breaking ios-internal, this CL keeps existing
components/task_scheduler_util APIs. Code in ChromeContentBrowserClient
and ios-internal will be migrated to the new APIs in separate CLs.
Then, old components/task_scheduler_util APIs will be deleted.

TBR=blundell@chromium.org
BUG=664996

Committed: https://crrev.com/4b4ca6521434859be5c614f961ec72b9e19826cc
Cr-Commit-Position: refs/heads/master@{#439481}
==========

[commit-bot: I haz the power, 2016-12-19 16:00:48]

Patchset 17 (id:??) landed as
https://crrev.com/4b4ca6521434859be5c614f961ec72b9e19826cc
Cr-Commit-Position: refs/heads/master@{#439481}