Split browser-specific and generic code in components/task_scheduler_util/.

components/task_scheduler_util/common/variations_util.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_TASK_SCHEDULER_UTIL_COMMON_VARIATIONS_UTIL_H_
+#define COMPONENTS_TASK_SCHEDULER_UTIL_COMMON_VARIATIONS_UTIL_H_
+
+#include <map>
+#include <string>
+#include <vector>
+
+#include "base/task_scheduler/scheduler_worker_pool_params.h"
+#include "base/threading/platform_thread.h"
+
+namespace task_scheduler_util {
+
+struct SchedulerImmutableWorkerPoolParams {
+  SchedulerImmutableWorkerPoolParams(const char* name_in,
+                                     base::ThreadPriority priority_hint_in);
+
+  const char* const name;

[robliao, 2016/12/15 21:26:46]

Doesn't the const violate std::vector's requirement that items be MoveAssignable
or MoveInsertable?

I'd be fine having accessors here or non-const.

[fdoray, 2016/12/15 21:48:49]

That's what I thought. I was surprised to see that it still compiled on Windows
after gab@ asked me to add const. I'll see what the bots say on other platforms.

[robliao, 2016/12/15 22:07:08]

While it may not fail now, at the point anyone tries to do anything in the
vector, bad things may happen.
The standard for C++11 is...
   The requirements that are imposed on the elements depend on the actual
operations performed on the container. 

So I guess so long as we're the only ones who need this, this will be fine.

[fdoray, 2016/12/16 13:06:43]

Acknowledged.

+  const base::ThreadPriority priority_hint;
+};
+
+// Returns a SchedulerWorkerPoolParams vector to initialize pools specified in
+// |constant_worker_pool_params_vector|. SchedulerWorkerPoolParams members
+// without a counterpart in SchedulerImmutableWorkerPoolParams are initialized
+// based of |variation_params|. Returns an empty vector on failure.
+std::vector<base::SchedulerWorkerPoolParams> GetWorkerPoolParams(
+    const std::vector<SchedulerImmutableWorkerPoolParams>
+        constant_worker_pool_params_vector,
+    const std::map<std::string, std::string>& variation_params);
+
+}  // namespace task_scheduler_util
+
+#endif  // COMPONENTS_TASK_SCHEDULER_UTIL_COMMON_VARIATIONS_UTIL_H_