Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2564953003: Fix reversed DCHECK() in ScreenOrientationProvider. (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
Reviewers:
clamy, blundell
CC:
blundell, chromium-reviews, darin-cc_chromium.org, jam, lunalu1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix reversed DCHECK() in ScreenOrientationProvider. Also fixes a typo. This is a follow-up from https://codereview.chromium.org/2391883006 BUG=612339 Committed: https://crrev.com/f2ae32c8f18e80cb12a37b359c11fe54eba38f94 Cr-Commit-Position: refs/heads/master@{#437874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/public/browser/screen_orientation_provider.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
mlamouri (slow - plz ping)
clamy@, PTAL +blundell@ and lunalu@ FYI
4 years ago (2016-12-10 14:01:00 UTC) #2
blundell
Thanks, Mounir! Do you think this addresses the test flake, or is that something different?
4 years ago (2016-12-12 11:52:44 UTC) #5
clamy
Thanks! Lgtm.
4 years ago (2016-12-12 12:39:07 UTC) #6
mlamouri (slow - plz ping)
On 2016/12/12 at 11:52:44, blundell wrote: > Thanks, Mounir! Do you think this addresses the ...
4 years ago (2016-12-12 13:39:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564953003/1
4 years ago (2016-12-12 13:40:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 15:12:15 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 15:14:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2ae32c8f18e80cb12a37b359c11fe54eba38f94
Cr-Commit-Position: refs/heads/master@{#437874}

Powered by Google App Engine
This is Rietveld 408576698