Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2561163005: Add video_fullscreen_orientation_lock_enabled to common_params_traits_macros.h (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add video_fullscreen_orientation_lock_enabled to common_params_traits_macros.h It was missing from https://codereview.chromium.org/2547533002 BUG=326572 R=mkwst@chromium.org Committed: https://crrev.com/910dbf7fba3d5b1e99fee67a46aaf6c19ab58b95 Cr-Commit-Position: refs/heads/master@{#437849}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove unrelated change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/common/common_param_traits_macros.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mlamouri (slow - plz ping)
mkwst@ PTAL
4 years ago (2016-12-10 14:10:51 UTC) #3
Mike West
LGTM
4 years ago (2016-12-12 08:23:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2561163005/40001
4 years ago (2016-12-12 10:23:01 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-12 11:53:16 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:33 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/910dbf7fba3d5b1e99fee67a46aaf6c19ab58b95
Cr-Commit-Position: refs/heads/master@{#437849}

Powered by Google App Engine
This is Rietveld 408576698