Reland "Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset #4 id:20002 of https…

Reland "Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset #4 id:20002 of https://codereview.chromium.org/2537893002/ )"

Reverted in https://codereview.chromium.org/2548883002/
Reason for relanding: turns out something else was causing these failures.
See details in https://bugs.chromium.org/p/chromium/issues/detail?id=670844#c17

TBR=avi@chromium.org,thakis@chromium.org,asargent@chromium.org
BUG=668707
Committed: https://crrev.com/72c1b445bdcf34230617c75b282104019fde3614
Cr-Commit-Position: refs/heads/master@{#437632}

[Alexander Semashko, 2016-12-09 17:34:02]

The CQ bit was checked by ahest@yandex-team.ru

[commit-bot: I haz the power, 2016-12-09 17:34:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 17:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 17:34:45]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[dmazzoni, 2016-12-09 17:59:52]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2016-12-09 17:59:52]

lgtm

rubberstamp lgtm because this is a re-land

(original reviewers, please double-check when you
have a chance)

[dmazzoni, 2016-12-09 17:59:57]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-12-09 18:00:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Semashko, 2016-12-09 18:49:36]

On 2016/12/09 17:59:52, dmazzoni wrote:
> lgtm
> 
> rubberstamp lgtm because this is a re-land
> 
> (original reviewers, please double-check when you
> have a chance)

Thanks!

Looks like asargent is sheriffing today, so there is no need to ping him
additionally, right?

Antony, please note that the original CL was reverted because it was thought to
cause massive test timeouts.
There is evidence (that looks strong to me) that it was not the cause really.
There is more info in https://crbug.com/670844.

[asargent_no_longer_on_chrome, 2016-12-09 18:53:27]

On 2016/12/09 18:49:36, Alexander Semashko wrote:
> On 2016/12/09 17:59:52, dmazzoni wrote:
> > lgtm
> > 
> > rubberstamp lgtm because this is a re-land
> > 
> > (original reviewers, please double-check when you
> > have a chance)
> 
> Thanks!
> 
> Looks like asargent is sheriffing today, so there is no need to ping him
> additionally, right?
> 
> Antony, please note that the original CL was reverted because it was thought
to
> cause massive test timeouts.
> There is evidence (that looks strong to me) that it was not the cause really.
> There is more info in https://crbug.com/670844.

Ok, I'll keep my eye out for it. Thanks for the heads up!

[commit-bot: I haz the power, 2016-12-09 20:40:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481306397252940, "parent_rev":
"14033b58b145beb8933d10dbca9bd7a7ead31eca", "commit_rev":
"1cd75c4e87e26a88e09f011df9ce61b78a8c3305"}

[commit-bot: I haz the power, 2016-12-09 20:41:18]

Description was changed from

==========
Reland "Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset
#4 id:20002 of https://codereview.chromium.org/2537893002/ )"

Reverted in https://codereview.chromium.org/2548883002/
Reason for relanding: turns out something else was causing these failures.
See details in https://bugs.chromium.org/p/chromium/issues/detail?id=670844#c17

TBR=avi@chromium.org,thakis@chromium.org,asargent@chromium.org
BUG=668707
==========

to

==========
Reland "Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset
#4 id:20002 of https://codereview.chromium.org/2537893002/ )"

Reverted in https://codereview.chromium.org/2548883002/
Reason for relanding: turns out something else was causing these failures.
See details in https://bugs.chromium.org/p/chromium/issues/detail?id=670844#c17

TBR=avi@chromium.org,thakis@chromium.org,asargent@chromium.org
BUG=668707

Review-Url: https://codereview.chromium.org/2564943002
==========

[commit-bot: I haz the power, 2016-12-09 20:41:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 14:40:07]

Description was changed from

==========
Reland "Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset
#4 id:20002 of https://codereview.chromium.org/2537893002/ )"

Reverted in https://codereview.chromium.org/2548883002/
Reason for relanding: turns out something else was causing these failures.
See details in https://bugs.chromium.org/p/chromium/issues/detail?id=670844#c17

TBR=avi@chromium.org,thakis@chromium.org,asargent@chromium.org
BUG=668707

Review-Url: https://codereview.chromium.org/2564943002
==========

to

==========
Reland "Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset
#4 id:20002 of https://codereview.chromium.org/2537893002/ )"

Reverted in https://codereview.chromium.org/2548883002/
Reason for relanding: turns out something else was causing these failures.
See details in https://bugs.chromium.org/p/chromium/issues/detail?id=670844#c17

TBR=avi@chromium.org,thakis@chromium.org,asargent@chromium.org
BUG=668707

Committed: https://crrev.com/72c1b445bdcf34230617c75b282104019fde3614
Cr-Commit-Position: refs/heads/master@{#437632}
==========

[commit-bot: I haz the power, 2016-12-12 14:40:08]

Patchset 1 (id:??) landed as
https://crrev.com/72c1b445bdcf34230617c75b282104019fde3614
Cr-Commit-Position: refs/heads/master@{#437632}