Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2548883002: Revert of Add thread checking to RunLoop, deprecate MessageLoopRunner. (Closed)

Created:
4 years ago by Ken Rockot(use gerrit already)
Modified:
4 years ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, vmpstr+watch_chromium.org, tfarina, yamaguchi+watch_chromium.org, oka+watch_chromium.org, jam, chromium-apps-reviews_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, sync-reviews_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add thread checking to RunLoop, deprecate MessageLoopRunner. (patchset #4 id:20002 of https://codereview.chromium.org/2537893002/ ) Reason for revert: Speculative revert in an effort to pinpoint the cause of http://crbug.com/670844 - will reland if the flake doesn't clear Original issue's description: > Add thread checker to base::RunLoop. > > The purpose is to make sure that after switching users of > MessageLoopRunner to RunLoop we won't lose any correctness checks. > > Also add a comment that encourages to use RunLoop where possible, and > rename GetQuitTaskForRunLoop to GetDeferredQuitTaskForRunLoop to convey > is purpose clearly. > > BUG=668707 > > Committed: https://crrev.com/dd10720676efff002490f702118e052dcd210f18 > Cr-Commit-Position: refs/heads/master@{#435924} TBR=avi@chromium.org,thakis@chromium.org,asargent@chromium.org,ahest@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=668707 Committed: https://crrev.com/f8675b380dff12f69ad3b61920f9e8fdcfcadae8 Cr-Commit-Position: refs/heads/master@{#436035}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M base/run_loop.h View 2 chunks +0 lines, -3 lines 0 comments Download
M base/run_loop.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/zip_file_creator_browsertest.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/sync/test/integration/dictionary_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/async_revalidation_manager_browsertest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/public/test/test_launcher.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/public/test/test_utils.h View 2 chunks +1 line, -7 lines 0 comments Download
M content/public/test/test_utils.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M extensions/test/result_catcher.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Ken Rockot(use gerrit already)
Created Revert of Add thread checking to RunLoop, deprecate MessageLoopRunner.
4 years ago (2016-12-02 21:30:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2548883002/1
4 years ago (2016-12-02 21:31:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-02 21:34:02 UTC) #5
commit-bot: I haz the power
4 years ago (2016-12-02 21:38:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8675b380dff12f69ad3b61920f9e8fdcfcadae8
Cr-Commit-Position: refs/heads/master@{#436035}

Powered by Google App Engine
This is Rietveld 408576698