[DeviceService] Move screen_orientation.mojom from //content to //device.

[DeviceService] Move screen_orientation.mojom from //content to //device.

Also moves screen_orientation_lock_types.mojom out from blink into //device.

This is the first CL to decouple screen orientation codes from //content.
Follow-up CLs will
  * migrate ScreenOrientationHostMsg_StartListening and
    ScreenOrientationHostMsg_StopListening IPC messages into this mojom file.
  * decouple content/renderer/screen_orientation/* into blink.
  * decouple content/browser/screen_orientation/* into //device.

BUG=612339
Committed: https://crrev.com/dfbaf46a8f088f494d65ca9621a912510f3fd10b
Cr-Commit-Position: refs/heads/master@{#438372}

[leonhsl(Using Gerrit), 2016-12-09 06:25:37]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 06:25:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 06:28:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 06:28:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[leonhsl(Using Gerrit), 2016-12-09 06:32:41]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[leonhsl(Using Gerrit), 2016-12-09 06:32:51]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-12-09 06:32:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2016-12-09 06:37:25]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 06:37:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 06:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 06:49:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2016-12-09 07:05:37]

Patchset #1 (id:20001) has been deleted

[leonhsl(Using Gerrit), 2016-12-09 07:05:50]

Patchset #1 (id:40001) has been deleted

[leonhsl(Using Gerrit), 2016-12-09 07:05:56]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 07:06:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 08:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 08:34:57]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[leonhsl(Using Gerrit), 2016-12-09 09:19:47]

leon.han@intel.com changed reviewers:
+ blundell@chromium.org, rockot@chromium.org

[leonhsl(Using Gerrit), 2016-12-09 09:19:48]

Hi, would you PTAL at this? Thanks. I suppose finally we should   put screen
orientation mojom files into //device, so I do this firstly before decoupling
codes.

https://codereview.chromium.org/2564653003/diff/60001/device/screen_orientati...
File device/screen_orientation/public/interfaces/screen_orientation.mojom
(right):

https://codereview.chromium.org/2564653003/diff/60001/device/screen_orientati...
device/screen_orientation/public/interfaces/screen_orientation.mojom:7: import
"third_party/WebKit/public/platform/modules/screen_orientation/screen_orientation_lock_types.mojom";
Seems the win_chromium_compile_dbg_ng failure indicates that we should also move
screen_orientation_lock_types.mojom into //device? I'm confused with the
dependencies now..

[leonhsl(Using Gerrit), 2016-12-09 10:03:01]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 10:03:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 11:15:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 11:15:48]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[blundell, 2016-12-09 15:34:42]

This looks good modulo that necessary change.

https://codereview.chromium.org/2564653003/diff/60001/device/screen_orientati...
File device/screen_orientation/public/interfaces/screen_orientation.mojom
(right):

https://codereview.chromium.org/2564653003/diff/60001/device/screen_orientati...
device/screen_orientation/public/interfaces/screen_orientation.mojom:7: import
"third_party/WebKit/public/platform/modules/screen_orientation/screen_orientation_lock_types.mojom";
On 2016/12/09 09:19:48, leonhsl wrote:
> Seems the win_chromium_compile_dbg_ng failure indicates that we should also
move
> screen_orientation_lock_types.mojom into //device? I'm confused with the
> dependencies now.. 

Yes, that's correct. It looks like //third_party/WebKit/public:mojo_bindings is
only meant to be depended on in Chromium by //content.

[leonhsl(Using Gerrit), 2016-12-12 06:24:57]

Description was changed from

==========
[DeviceService] Move screen_orientation.mojom from //content to //device.

This is the first CL to decouple screen orientation codes from //content.
Follow-up CLs will
  * migrate ScreenOrientationHostMsg_StartListening and
    ScreenOrientationHostMsg_StopListening IPC messages into this mojom file.
  * decouple content/renderer/screen_orientation/* into blink.
  * decouple content/browser/screen_orientation/* into //device.

BUG=612339
==========

to

==========
[DeviceService] Move screen_orientation.mojom from //content to //device.

Also moves screen_orientation_lock_types.mojom out from blink into //device.

This is the first CL to decouple screen orientation codes from //content.
Follow-up CLs will
  * migrate ScreenOrientationHostMsg_StartListening and
    ScreenOrientationHostMsg_StopListening IPC messages into this mojom file.
  * decouple content/renderer/screen_orientation/* into blink.
  * decouple content/browser/screen_orientation/* into //device.

BUG=612339
==========

[leonhsl(Using Gerrit), 2016-12-12 07:00:59]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 07:01:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 09:03:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 09:03:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[leonhsl(Using Gerrit), 2016-12-12 09:42:32]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 09:42:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2016-12-12 09:48:28]

leon.han@intel.com changed reviewers:
+ kinuko@chromium.org, tsepez@chromium.org

[leonhsl(Using Gerrit), 2016-12-12 09:48:29]

Uploaded ps#2 and add more reviewers, PTAL, Thanks.

blundell@: For overall review.
kinuko@:   For OWNER review of //content/ and //third_party/WebKit/public/.
Tom:       For OWNER review of mojom related files.
Ken:       For OWNER review of //device/.

https://codereview.chromium.org/2564653003/diff/60001/device/screen_orientati...
File device/screen_orientation/public/interfaces/screen_orientation.mojom
(right):

https://codereview.chromium.org/2564653003/diff/60001/device/screen_orientati...
device/screen_orientation/public/interfaces/screen_orientation.mojom:7: import
"third_party/WebKit/public/platform/modules/screen_orientation/screen_orientation_lock_types.mojom";
On 2016/12/09 15:34:42, blundell wrote:
> On 2016/12/09 09:19:48, leonhsl wrote:
> > Seems the win_chromium_compile_dbg_ng failure indicates that we should also
> move
> > screen_orientation_lock_types.mojom into //device? I'm confused with the
> > dependencies now.. 
> 
> Yes, that's correct. It looks like //third_party/WebKit/public:mojo_bindings
is
> only meant to be depended on in Chromium by //content.

Done and Thanks!

[commit-bot: I haz the power, 2016-12-12 11:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 11:35:18]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[leonhsl(Using Gerrit), 2016-12-12 11:52:22]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 11:52:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[blundell, 2016-12-12 12:30:46]

lgtm, thanks

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
File content/public/browser/screen_orientation_provider.cc (right):

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
content/public/browser/screen_orientation_provider.cc:18: using
::device::mojom::ScreenOrientationLockResult;
same tiny nit.

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
File content/public/browser/screen_orientation_provider.h (right):

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
content/public/browser/screen_orientation_provider.h:56: void
NotifyLockResult(::device::mojom::ScreenOrientationLockResult result);
tiny nit: the leading :: shouldn't be necessary here.

https://codereview.chromium.org/2564653003/diff/80001/content/renderer/screen...
File content/renderer/screen_orientation/screen_orientation_dispatcher.h
(right):

https://codereview.chromium.org/2564653003/diff/80001/content/renderer/screen...
content/renderer/screen_orientation/screen_orientation_dispatcher.h:23: using
::device::mojom::ScreenOrientationAssociatedPtr;
same nit everywhere that this applies.

[commit-bot: I haz the power, 2016-12-12 12:38:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 12:38:48]

Dry run: This issue passed the CQ dry run.

[kinuko, 2016-12-12 14:44:08]

looking good, let me make sure one thing

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
File content/public/browser/DEPS (right):

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
content/public/browser/DEPS:2: "+device/screen_orientation/public/interfaces",
I assume these new deps in content are going to be removed once we decouple
screen_orientation code into device code-- am I right?

[Tom Sepez, 2016-12-12 16:31:30]

mojom LGTM

[leonhsl(Using Gerrit), 2016-12-13 02:34:57]

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
File content/public/browser/DEPS (right):

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
content/public/browser/DEPS:2: "+device/screen_orientation/public/interfaces",
On 2016/12/12 14:44:08, kinuko wrote:
> I assume these new deps in content are going to be removed once we decouple
> screen_orientation code into device code-- am I right?

Yeah that's correct, finally all screen_orientation related codes would  be
decoupled into //device or blink.

[kinuko, 2016-12-13 02:54:26]

lgtm, thanks

[leonhsl(Using Gerrit), 2016-12-13 03:36:21]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 03:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[leonhsl(Using Gerrit), 2016-12-13 03:39:58]

Uploaded ps#3. And friendly ping Ken for OWNER review of //device, Thanks.

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
File content/public/browser/screen_orientation_provider.cc (right):

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
content/public/browser/screen_orientation_provider.cc:18: using
::device::mojom::ScreenOrientationLockResult;
On 2016/12/12 12:30:45, blundell wrote:
> same tiny nit.

Done.

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
File content/public/browser/screen_orientation_provider.h (right):

https://codereview.chromium.org/2564653003/diff/80001/content/public/browser/...
content/public/browser/screen_orientation_provider.h:56: void
NotifyLockResult(::device::mojom::ScreenOrientationLockResult result);
On 2016/12/12 12:30:46, blundell wrote:
> tiny nit: the leading :: shouldn't be necessary here.

Done.

https://codereview.chromium.org/2564653003/diff/80001/content/renderer/screen...
File content/renderer/screen_orientation/screen_orientation_dispatcher.h
(right):

https://codereview.chromium.org/2564653003/diff/80001/content/renderer/screen...
content/renderer/screen_orientation/screen_orientation_dispatcher.h:23: using
::device::mojom::ScreenOrientationAssociatedPtr;
On 2016/12/12 12:30:46, blundell wrote:
> same nit everywhere that this applies.

Done for everywhere for this CL. Thanks!

[commit-bot: I haz the power, 2016-12-13 06:49:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 06:49:50]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-12-13 19:07:07]

lgtm

[leonhsl(Using Gerrit), 2016-12-14 00:56:01]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2016-12-14 00:56:02]

The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org,
tsepez@chromium.org, blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/2564653003/#ps100001
(title: "Address nits from blundell@")

[commit-bot: I haz the power, 2016-12-14 00:56:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 01:05:16]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481676961851740,
"parent_rev": "0c73c4aee41ea8a3cb2db555294681a4010ebcf2", "commit_rev":
"812f03592ada1ec91928d3e1da9f258b24526c32"}

[commit-bot: I haz the power, 2016-12-14 01:05:42]

Description was changed from

==========
[DeviceService] Move screen_orientation.mojom from //content to //device.

Also moves screen_orientation_lock_types.mojom out from blink into //device.

This is the first CL to decouple screen orientation codes from //content.
Follow-up CLs will
  * migrate ScreenOrientationHostMsg_StartListening and
    ScreenOrientationHostMsg_StopListening IPC messages into this mojom file.
  * decouple content/renderer/screen_orientation/* into blink.
  * decouple content/browser/screen_orientation/* into //device.

BUG=612339
==========

to

==========
[DeviceService] Move screen_orientation.mojom from //content to //device.

Also moves screen_orientation_lock_types.mojom out from blink into //device.

This is the first CL to decouple screen orientation codes from //content.
Follow-up CLs will
  * migrate ScreenOrientationHostMsg_StartListening and
    ScreenOrientationHostMsg_StopListening IPC messages into this mojom file.
  * decouple content/renderer/screen_orientation/* into blink.
  * decouple content/browser/screen_orientation/* into //device.

BUG=612339

Review-Url: https://codereview.chromium.org/2564653003
==========

[commit-bot: I haz the power, 2016-12-14 01:05:43]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-12-14 01:11:40]

Description was changed from

==========
[DeviceService] Move screen_orientation.mojom from //content to //device.

Also moves screen_orientation_lock_types.mojom out from blink into //device.

This is the first CL to decouple screen orientation codes from //content.
Follow-up CLs will
  * migrate ScreenOrientationHostMsg_StartListening and
    ScreenOrientationHostMsg_StopListening IPC messages into this mojom file.
  * decouple content/renderer/screen_orientation/* into blink.
  * decouple content/browser/screen_orientation/* into //device.

BUG=612339

Review-Url: https://codereview.chromium.org/2564653003
==========

to

==========
[DeviceService] Move screen_orientation.mojom from //content to //device.

Also moves screen_orientation_lock_types.mojom out from blink into //device.

This is the first CL to decouple screen orientation codes from //content.
Follow-up CLs will
  * migrate ScreenOrientationHostMsg_StartListening and
    ScreenOrientationHostMsg_StopListening IPC messages into this mojom file.
  * decouple content/renderer/screen_orientation/* into blink.
  * decouple content/browser/screen_orientation/* into //device.

BUG=612339

Committed: https://crrev.com/dfbaf46a8f088f494d65ca9621a912510f3fd10b
Cr-Commit-Position: refs/heads/master@{#438372}
==========

[commit-bot: I haz the power, 2016-12-14 01:11:42]

Patchset 3 (id:??) landed as
https://crrev.com/dfbaf46a8f088f494d65ca9621a912510f3fd10b
Cr-Commit-Position: refs/heads/master@{#438372}