device/screen_orientation/public/interfaces/screen_orientation.mojom - Issue 2564653003: [DeviceService] Move screen_orientation.mojom from //content to //device.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: device/screen_orientation/public/interfaces/screen_orientation.mojom

Issue 2564653003: [DeviceService] Move screen_orientation.mojom from //content to //device. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module content.mojom;	5 module device.mojom;

6	6

7 import "third_party/WebKit/public/platform/modules/screen_orientation/screen_ori entation_lock_types.mojom";	7 import "third_party/WebKit/public/platform/modules/screen_orientation/screen_ori entation_lock_types.mojom";
	leonhsl(Using Gerrit) 2016/12/09 09:19:48 Seems the win_chromium_compile_dbg_ng failure indi Seems the win_chromium_compile_dbg_ng failure indicates that we should also move screen_orientation_lock_types.mojom into //device? I'm confused with the dependencies now.. blundell 2016/12/09 15:34:42 Yes, that's correct. It looks like //third_party/W Show quoted text On 2016/12/09 09:19:48, leonhsl wrote: > Seems the win_chromium_compile_dbg_ng failure indicates that we should also move > screen_orientation_lock_types.mojom into //device? I'm confused with the > dependencies now.. Yes, that's correct. It looks like //third_party/WebKit/public:mojo_bindings is only meant to be depended on in Chromium by //content. leonhsl(Using Gerrit) 2016/12/12 09:48:29 Done and Thanks! Show quoted text On 2016/12/09 15:34:42, blundell wrote: > On 2016/12/09 09:19:48, leonhsl wrote: > > Seems the win_chromium_compile_dbg_ng failure indicates that we should also > move > > screen_orientation_lock_types.mojom into //device? I'm confused with the > > dependencies now.. > > Yes, that's correct. It looks like //third_party/WebKit/public:mojo_bindings is > only meant to be depended on in Chromium by //content. Done and Thanks!
8	8

9 interface ScreenOrientation {	9 interface ScreenOrientation {

10 LockOrientation(blink.mojom.ScreenOrientationLockType orientation) =>	10 LockOrientation(blink.mojom.ScreenOrientationLockType orientation) =>

11 (blink.mojom.ScreenOrientationLockResult result);	11 (blink.mojom.ScreenOrientationLockResult result);

12 UnlockOrientation();	12 UnlockOrientation();

13 };	13 };

OLD	NEW

« no previous file with comments | « device/screen_orientation/public/interfaces/OWNERS ('k') | no next file » | no next file with comments »