Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Comments from esprehn. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp ('K') | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index f23032813ecfc83b9df814bff317a5c8fe1b9308..85b6e2f4f4444b76d1b61e3372ece6a5800a161c 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -1585,8 +1585,8 @@ LocalFrame* WebLocalFrameImpl::createChildFrame(
WebFrameOwnerProperties ownerProperties(
ownerElement->scrollingMode(), ownerElement->marginWidth(),
ownerElement->marginHeight(), ownerElement->allowFullscreen(),
- ownerElement->allowPaymentRequest(), ownerElement->csp(),
- ownerElement->delegatedPermissions());
+ ownerElement->allowPaymentRequest(), ownerElement->isDisplayNone(),
+ ownerElement->csp(), ownerElement->delegatedPermissions());
// FIXME: Using subResourceAttributeName as fallback is not a perfect
// solution. subResourceAttributeName returns just one attribute name. The
// element might not have the attribute, and there might be other attributes
« third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp ('K') | « third_party/WebKit/Source/web/WebFrame.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698