Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Comments from esprehn. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
index cebcc0b20d7aba39bb64b8c0c9697deed0f4a954..8e9757fc9e54137bca41afe801c7c45c4abd4b67 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
@@ -221,6 +221,13 @@ void HTMLFrameOwnerElement::disposeWidgetSoon(Widget* widget) {
widget->dispose();
}
+void HTMLFrameOwnerElement::frameOwnerPropertiesChanged() {
+ // Don't notify about updates if contentFrame() is null, for example when
+ // the subframe hasn't been created yet.
+ if (contentFrame())
+ document().frame()->loader().client()->didChangeFrameOwnerProperties(this);
+}
+
void HTMLFrameOwnerElement::dispatchLoad() {
dispatchScopedEvent(Event::create(EventTypeNames::load));
}
@@ -243,6 +250,16 @@ void HTMLFrameOwnerElement::setWidget(Widget* widget) {
if (widget == m_widget)
return;
+ Document* doc = contentDocument();
+ if (doc && doc->frame()) {
+ bool isDisplayNone = this->isDisplayNone();
esprehn 2016/12/16 21:29:44 If you remove the local you can void the this-> i
erikchen 2016/12/16 22:42:11 Done. [If you wish to avoid locals, sure, not sure
+ bool willBeDisplayNone = !widget;
+ if (isDisplayNone != willBeDisplayNone) {
+ doc->willChangeFrameOwnerProperties(marginWidth(), marginHeight(),
+ scrollingMode(), willBeDisplayNone);
+ }
+ }
+
if (m_widget) {
if (m_widget->parent())
moveWidgetToParentSoon(m_widget.get(), 0);
@@ -250,6 +267,7 @@ void HTMLFrameOwnerElement::setWidget(Widget* widget) {
}
m_widget = widget;
+ frameOwnerPropertiesChanged();
LayoutPart* layoutPart = toLayoutPart(layoutObject());
LayoutPartItem layoutPartItem = LayoutPartItem(layoutPart);

Powered by Google App Engine
This is Rietveld 408576698