Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Comments from esprehn. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrame.cpp
diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp
index e7625d25995f2e6b7a662398127fa8e65f8ebe77..296e64027ac88f4a7a51b4c9bbd49c0bde7146bb 100644
--- a/third_party/WebKit/Source/web/WebFrame.cpp
+++ b/third_party/WebKit/Source/web/WebFrame.cpp
@@ -146,7 +146,8 @@ void WebFrame::setFrameOwnerProperties(
if (frame->isLocalFrame()) {
toLocalFrame(frame)->document()->willChangeFrameOwnerProperties(
properties.marginWidth, properties.marginHeight,
- static_cast<ScrollbarMode>(properties.scrollingMode));
+ static_cast<ScrollbarMode>(properties.scrollingMode),
+ properties.isDisplayNone);
}
owner->setScrollingMode(properties.scrollingMode);
@@ -154,6 +155,7 @@ void WebFrame::setFrameOwnerProperties(
owner->setMarginHeight(properties.marginHeight);
owner->setAllowFullscreen(properties.allowFullscreen);
owner->setAllowPaymentRequest(properties.allowPaymentRequest);
+ owner->setIsDisplayNone(properties.isDisplayNone);
owner->setCsp(properties.requiredCsp);
owner->setDelegatedpermissions(properties.delegatedPermissions);
}

Powered by Google App Engine
This is Rietveld 408576698