Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2564493003:
Cleanup sign checking in safe math code (Closed)
DescriptionCleanup sign checking in safe math code
Signed comparison is less code and matches the optimal compiler
heuristics better than masking.
TBR=scottmg
NOTRY=true
Committed: https://crrev.com/99bfa52d9dea53984ae4da5ee44eff0002928453
Cr-Commit-Position: refs/heads/master@{#437342}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 18 (11 generated)
Description was changed from ========== Cleanup sign hecking in safe math code Signed comparison is less code and more optimal than masking. ========== to ========== Cleanup sign hecking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. ==========
Description was changed from ========== Cleanup sign hecking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. ========== to ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. ==========
Description was changed from ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. ========== to ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. TBR=scottmg ==========
jschuh@chromium.org changed reviewers: + scottmg@chromium.org
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. TBR=scottmg ========== to ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. TBR=scottmg NOTRY=true ==========
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2564493003/diff/1/base/numerics/safe_math_impl.h File base/numerics/safe_math_impl.h (right): https://codereview.chromium.org/2564493003/diff/1/base/numerics/safe_math_imp... base/numerics/safe_math_impl.h:49: // Cast to unsigned since right shift on signed is undefined. You're not casting to unsigned.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481230921645590, "parent_rev":
"781f2fc1aee2e85de1531d2840aac9e45ceafde6", "commit_rev":
"8da3e6dd7c22d6208375fca70a44252ddaea6ec7"}
Message was sent while issue was closed.
Description was changed from ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. TBR=scottmg NOTRY=true ========== to ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. TBR=scottmg NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. TBR=scottmg NOTRY=true ========== to ========== Cleanup sign checking in safe math code Signed comparison is less code and matches the optimal compiler heuristics better than masking. TBR=scottmg NOTRY=true Committed: https://crrev.com/99bfa52d9dea53984ae4da5ee44eff0002928453 Cr-Commit-Position: refs/heads/master@{#437342} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/99bfa52d9dea53984ae4da5ee44eff0002928453 Cr-Commit-Position: refs/heads/master@{#437342}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2563003003/ by jschuh@chromium.org. The reason for reverting is: This change was not a performance improvement.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
