Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 2563003003: Revert of Cleanup sign checking in safe math code (Closed)

Created:
4 years ago by jschuh
Modified:
4 years ago
Reviewers:
scottmg
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleanup sign checking in safe math code (patchset #1 id:1 of https://codereview.chromium.org/2564493003/ ) Reason for revert: This change was not a performance improvement. Original issue's description: > Cleanup sign checking in safe math code > > Signed comparison is less code and matches the optimal compiler > heuristics better than masking. > > TBR=scottmg > NOTRY=true > > Committed: https://crrev.com/99bfa52d9dea53984ae4da5ee44eff0002928453 > Cr-Commit-Position: refs/heads/master@{#437342} TBR=scottmg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f2896ed53d887af6aa4f61aa3eb508f2599c2708 Cr-Commit-Position: refs/heads/master@{#437580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M base/numerics/safe_conversions_impl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/numerics/safe_math_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jschuh
Created Revert of Cleanup sign checking in safe math code
4 years ago (2016-12-09 17:39:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563003003/1
4 years ago (2016-12-09 17:40:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 17:41:20 UTC) #6
scottmg
lgtm
4 years ago (2016-12-09 18:25:38 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2896ed53d887af6aa4f61aa3eb508f2599c2708
Cr-Commit-Position: refs/heads/master@{#437580}

Powered by Google App Engine
This is Rietveld 408576698