Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html

Issue 2564493002: Make WebSocket available again in service workers (Closed)
Patch Set: Removed unnecessary line Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html
new file mode 100644
index 0000000000000000000000000000000000000000..babedbeace2a1b9c0244560210817bad6c10696b
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html
@@ -0,0 +1,27 @@
+<!DOCTYPE html>
+<title>Service Worker: WebSockets can be created in a Service Worker</title>
+<script src="/resources/testharness.js"></script>
+<script src="/resources/testharnessreport.js"></script>
+<script src="../resources/test-helpers.js"></script>
+<script>
+promise_test(t => {
+ const SCRIPT = 'resources/simple.js';
+ const SCOPE = 'resources/blank.html';
+ let registration;
+ return service_worker_unregister_and_register(t, SCRIPT, SCOPE)
+ .then(r => {
+ add_completion_callback(() => { r.unregister(); });
+ registration = r;
+ return wait_for_state(t, r.installing, 'activated');
+ })
+ .then(() => {
+ return new Promise(resolve => {
+ navigator.serviceWorker.onmessage = t.step_func(msg => {
falken 2016/12/08 13:12:30 generally you don't need step_func in promise chai
tyoshino (SeeGerritForStatus) 2016/12/08 13:50:04 Yes, but this line is setting a handler function t
+ assert_equals(msg.data, 'PASS');
+ resolve();
+ });
+ registration.active.postMessage({});
+ });
+ });
+}, 'Verify WebSockets can be created in a Service Worker');
falken 2016/12/08 13:12:30 nit: indent line 26 an additional two spaces
tyoshino (SeeGerritForStatus) 2016/12/08 13:50:04 Done.
+</script>

Powered by Google App Engine
This is Rietveld 408576698