third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html - Issue 2564493002: Make WebSocket available again in service workers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html

Issue 2564493002: Make WebSocket available again in service workers (Closed)

Patch Set: Removed unnecessary line Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/resources/simple.js ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/resources/simple.js ('k') | third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Service Worker: WebSockets can be created in a Service Worker</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script src="../resources/test-helpers.js"></script>

	6 <script>

	7 promise_test(t => {

	8 const SCRIPT = 'resources/simple.js';

	9 const SCOPE = 'resources/blank.html';

	10 let registration;

	11 return service_worker_unregister_and_register(t, SCRIPT, SCOPE)

	12 .then(r => {

	13 add_completion_callback(() => { r.unregister(); });

	14 registration = r;

	15 return wait_for_state(t, r.installing, 'activated');

	16 })

	17 .then(() => {

	18 return new Promise(resolve => {

	19 navigator.serviceWorker.onmessage = t.step_func(msg => {
	falken 2016/12/08 13:12:30 generally you don't need step_func in promise chai generally you don't need step_func in promise chain promise_tests since an error in the promise chain bubbles up to result in a rejected promise returned by the test. you could confirm manually. tyoshino (SeeGerritForStatus) 2016/12/08 13:50:04 Yes, but this line is setting a handler function t Show quoted text On 2016/12/08 13:12:30, falken wrote: > generally you don't need step_func in promise chain promise_tests since an error > in the promise chain bubbles up to result in a rejected promise returned by the > test. you could confirm manually. Yes, but this line is setting a handler function to onmessage. Not inside .then() or the Promise construction function where any error will bubble up to the Promise and get propagated to itself or the promise returned by the .then(). AssertionErrors wouldn't get handled correctly by the testharness unless we insert step_func() here.
	20 assert_equals(msg.data, 'PASS');

	21 resolve();

	22 });

	23 registration.active.postMessage({});

	24 });

	25 });

	26 }, 'Verify WebSockets can be created in a Service Worker');
	falken 2016/12/08 13:12:30 nit: indent line 26 an additional two spaces nit: indent line 26 an additional two spaces tyoshino (SeeGerritForStatus) 2016/12/08 13:50:04 Done. Show quoted text On 2016/12/08 13:12:30, falken wrote: > nit: indent line 26 an additional two spaces Done.
	27 </script>

OLD	NEW