third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp - Issue 2564493002: Make WebSocket available again in service workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

Issue 2564493002: Make WebSocket available again in service workers (Closed)

Patch Set: Removed unnecessary line Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

diff --git a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

index 95c0ded764028caec622a5dee76bd01b8675ae98..d2edd64dd78a763d56d76c52f5186e5f5adabf1a 100644

--- a/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

+++ b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

@@ -174,7 +174,7 @@ bool DocumentWebSocketChannel::connect(const KURL& url,

protocol.split(", ", true, protocols);

}

- if (document()->frame()) {

+ if (document()->frame() && document()->frame()->interfaceProvider()) {

// Initialize the WebSocketHandle with the frame's InterfaceProvider to

// provide the WebSocket implementation with context about this frame.

// This is important so that the browser can show UI associated with